This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Add expired license restrictions and new plan#47251
Merged
Merged
Conversation
…xpires. Add new EnterpriseExtension plan
kopancek
suggested changes
Feb 1, 2023
mrnugget
approved these changes
Feb 1, 2023
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 0e47fba...d703eae.
|
11 tasks
unknwon
approved these changes
Feb 1, 2023
unknwon
left a comment
Contributor
There was a problem hiding this comment.
Blind approval because I did not look at the code, but the demo looks great though 🎉
kopancek
approved these changes
Feb 1, 2023
mrnugget
added a commit
that referenced
this pull request
Feb 1, 2023
Co-authored-by: Milan Freml <milan.freml@sourcegraph.com> Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plans now have an
ExpiredFeaturesas well as aFeaturesfield, which allows us to specific features to remain active when a plan expires.The 3 day grace period after a license has expired has been removed. Instead, a site-wide warning will be displayed one week before a license expires. After the expiry date is reached, Sourcegraph usage will be restricted.
Users' admin level cannot be modified when a license is expired.
See Loom: https://www.loom.com/share/9730f92598534c26932b8b07f683f502
Possible TODOs:
ExpiredFeaturesto all the other licenses. Possibly the same two (SSO+ACLs) where applicablemain-dry-runto test the integration tests. I don't know if they don't bother using unexpired licenses.Test plan
Update failing tests