This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Add repo filtering to Gerrit code host connections#47021
Merged
pjlast merged 8 commits intoJan 27, 2023
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 1809061...d2df354.
|
sashaostrikov
approved these changes
Jan 27, 2023
sashaostrikov
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Added a couple of questions about naming and unused property.
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 1a2b5fd and 5af62f4 or learn more. Open explanation
|
sashaostrikov
approved these changes
Jan 27, 2023
sashaostrikov
left a comment
Contributor
There was a problem hiding this comment.
LGTM [2]! Noticed all naming fixes, left a couple of comments in tests.
kopancek
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Gerrit code host config option to specify specific projects on Gerrit.
Test plan
Add unit tests