This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search: Fix query input overflow behavior on search home page#46922
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff eb00425...769e547.
|
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 769e547 and b7f51e3 or learn more. Open explanation
|
sashaostrikov
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported here https://sourcegraph.slack.com/archives/C020S8AT3LN/p1674511890273459, the search input is overflowing the container when the input is really long. This only happens on the search homepage, it works as expected on the search result page.
Before/after video:
sg-search-input-fix.mp4
Test plan
Manual testing, see video.
App preview:
Check out the client app preview documentation to learn more.