This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Change code host connection checks to talk HTTP#46918
Merged
Merged
Conversation
Full context: https://github.com/sourcegraph/sourcegraph/issues/46915 This changes the connection checks to test what we're after: can we talk to the code hosts' API via HTTP? Because as it turns out, in some customer environments we can't do a TCP dial, because proxies block it. In that case an HTTP call makes even more sense, because if that succeeds we know we can talk to the API. The other change in here is to not hard-fail the repository syncing if the connection check fails. Until we're confident that the checks work exactly as we want them to, we only print a warning.
kopancek
approved these changes
Jan 25, 2023
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 8a9806a...23e2df9.
|
sashaostrikov
approved these changes
Jan 25, 2023
This was referenced Jan 25, 2023
mrnugget
added a commit
that referenced
this pull request
Jan 25, 2023
Full context: https://github.com/sourcegraph/sourcegraph/issues/46915 This changes the connection checks to test what we're after: can we talk to the code hosts' API via HTTP? Because as it turns out, in some customer environments we can't do a TCP dial, because proxies block it. In that case an HTTP call makes even more sense, because if that succeeds we know we can talk to the API. The other change in here is to not hard-fail the repository syncing if the connection check fails. Until we're confident that the checks work exactly as we want them to, we only print a warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full context: https://github.com/sourcegraph/sourcegraph/issues/46915
This changes the connection checks to test what we're after: can we talk to the code hosts' API via HTTP?
Because as it turns out, in some customer environments we can't do a TCP dial, because proxies block it. In that case an HTTP call makes even more sense, because if that succeeds we know we can talk to the API.
The other change in here is to not hard-fail the repository syncing if the connection check fails. Until we're confident that the checks work exactly as we want them to, we only print a warning.
cc @varsanojidan we need to do something similar for ADO but we didn't do that in this PR because we don't have an account yet and aren't confident in our abilities to properly test this (which we should for a patch release). And since ADO is not out in the wild yet.
Test plan