Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

repos: show the corrupted statistic on admin page#46412

Merged
burmudar merged 3 commits into
mainfrom
wb/repo/corrupted-ui-stat
Jan 16, 2023
Merged

repos: show the corrupted statistic on admin page#46412
burmudar merged 3 commits into
mainfrom
wb/repo/corrupted-ui-stat

Conversation

@burmudar

@burmudar burmudar commented Jan 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Show the amount of corrupted repos as reported by the repository stats
graphql query when corrupted > 0

Screenshot 2023-01-13 at 13 47 36

Test plan

manual testing

@cla-bot cla-bot Bot added the cla-signed label Jan 13, 2023
This was referenced Jan 13, 2023
Merged
Merged
@burmudar Graphite App

burmudar commented Jan 13, 2023

Copy link
Copy Markdown
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Jan 13, 2023 •
edited
Loading

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (+0.34 kb) 0.00% (+0.34 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 7e05e36 and 1ccd8e5 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@burmudar burmudar requested a review from a team January 13, 2023 11:43
sashaostrikov
sashaostrikov approved these changes Jan 13, 2023
View reviewed changes

@sashaostrikov sashaostrikov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Should we also support filtering by corrupted repos?

@burmudar

burmudar commented Jan 13, 2023

Copy link
Copy Markdown
Contributor Author

LGTM!

Should we also support filtering by corrupted repos?

Already done :D https://github.com/sourcegraph/sourcegraph/pull/46413 ... sadly it's build is failing since it needs a smol method from this stack of PRs

@burmudar burmudar force-pushed the wb/repo/corrupted-stat-graphql branch from 52dd439 to 74d8a9a Compare January 13, 2023 12:23
@burmudar burmudar force-pushed the wb/repo/corrupted-ui-stat branch from 967ffb9 to 1fe7ece Compare January 13, 2023 12:23
@burmudar burmudar force-pushed the wb/repo/corrupted-stat-graphql branch from 74d8a9a to 15d7ec7 Compare January 13, 2023 12:32
@burmudar burmudar force-pushed the wb/repo/corrupted-ui-stat branch from 1fe7ece to 44e3d97 Compare January 13, 2023 12:32
@burmudar burmudar force-pushed the wb/repo/corrupted-stat-graphql branch from 15d7ec7 to 3e8e209 Compare January 13, 2023 12:38
@burmudar burmudar force-pushed the wb/repo/corrupted-ui-stat branch from 44e3d97 to 9bcbfd7 Compare January 13, 2023 12:38
@burmudar burmudar self-assigned this Jan 13, 2023
mrnugget
mrnugget approved these changes Jan 16, 2023
View reviewed changes
Comment thread client/web/src/site-admin/SiteAdminRepositoriesPage.tsx Outdated
@burmudar burmudar force-pushed the wb/repo/corrupted-stat-graphql branch from 3e8e209 to a955db9 Compare January 16, 2023 13:39
@burmudar burmudar force-pushed the wb/repo/corrupted-ui-stat branch from 9bcbfd7 to ddd9fb0 Compare January 16, 2023 13:39
@burmudar burmudar force-pushed the wb/repo/corrupted-stat-graphql branch from a955db9 to cd40e0c Compare January 16, 2023 13:58
@burmudar burmudar force-pushed the wb/repo/corrupted-ui-stat branch from ddd9fb0 to f27354b Compare January 16, 2023 13:58
@burmudar Graphite App

burmudar commented Jan 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

❌ This merge job failed. This pull request was not merged
Stack job ID: ANkhuAH5uGZvSNzCLWgo.
See details on graphite.dev

@burmudar burmudar force-pushed the wb/repo/corrupted-stat-graphql branch from cd40e0c to 950c388 Compare January 16, 2023 14:53
@burmudar burmudar force-pushed the wb/repo/corrupted-ui-stat branch from f27354b to 7e05e36 Compare January 16, 2023 14:53
Base automatically changed from wb/repo/corrupted-stat-graphql to main January 16, 2023 15:41
@burmudar burmudar enabled auto-merge (squash) January 16, 2023 15:41
@burmudar burmudar merged commit 707b79c into main Jan 16, 2023
@burmudar burmudar deleted the wb/repo/corrupted-ui-stat branch January 16, 2023 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mrnugget mrnugget mrnugget approved these changes

@sashaostrikov sashaostrikov sashaostrikov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@burmudar burmudar

Labels

cla-signed i-acknowledge-this-goes-into-the-release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@burmudar @sg-e2e-regression-test-bob @mrnugget @sashaostrikov