This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Add Bitbucket Cloud permissions syncing#46312
Merged
pjlast merged 13 commits intoJan 16, 2023
Merged
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 7d33526 and 573a8bb or learn more. Open explanation
|
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff e512427...7d33526.
|
kopancek
reviewed
Jan 11, 2023
Comment on lines
+34
to
+35
| AuthURL: bbURL + "/site/oauth2/authorize", | ||
| TokenURL: bbURL + "/site/oauth2/access_token", |
Contributor
There was a problem hiding this comment.
Could we use JoinPath instead of naively merging strings for URL paths?
| reposURL = "/2.0/repositories" | ||
| } else { | ||
| next, err = c.page(ctx, fmt.Sprintf("/2.0/repositories/%s", accountName), nil, pageToken, &repos) | ||
| reposURL = fmt.Sprintf("/2.0/repositories/%s", accountName) |
Contributor
There was a problem hiding this comment.
For adding path params we should probably use PathEscape instead.
mrnugget
approved these changes
Jan 13, 2023
Comment on lines
+182
to
+186
| bbcloudProviders, bbcloudProblems, bbcloudWarnings, bbcloudInvalidConnections := bitbucketcloud.NewAuthzProviders(db, bitbucketCloudConns, cfg.SiteConfig().AuthProviders) | ||
| providers = append(providers, bbcloudProviders...) | ||
| seriousProblems = append(seriousProblems, bbcloudProblems...) | ||
| warnings = append(warnings, bbcloudWarnings...) | ||
| invalidConnections = append(invalidConnections, bbcloudInvalidConnections...) |
Contributor
There was a problem hiding this comment.
wow (comment unrelated to this PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds permissions syncing for Bitbucket Cloud code host connections.
Loom: https://www.loom.com/share/1378727858244c8394d0ce705e4a85ae
Test plan
Unit tests added. I also did manual verifications and confirmed things like token refreshing.