Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Revert "batches: use user name/e-mail with unauthored batch specs"#46234

Merged
indradhanush merged 1 commit into
mainfrom
revert-43828-aharvey/add-author-information-on-ssbc
Jan 9, 2023
Merged

Revert "batches: use user name/e-mail with unauthored batch specs"#46234
indradhanush merged 1 commit into
mainfrom
revert-43828-aharvey/add-author-information-on-ssbc

Conversation

@indradhanush

@indradhanush indradhanush commented Jan 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts sourcegraph/sourcegraph#43828

E2E is failing.

Test plan

Builds should pass.

@cla-bot cla-bot Bot added the cla-signed label Jan 9, 2023
@sourcegraph-bot

sourcegraph-bot commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff c5cb3da...fa4ba61.

Notify File(s)
@efritz enterprise/cmd/worker/internal/batches/workers/batch_spec_workspace_creator.go
@eseliger enterprise/cmd/worker/internal/batches/workers/batch_spec_workspace_creator.go
enterprise/internal/batches/store/author/author.go
enterprise/internal/batches/store/author/author_test.go
enterprise/internal/batches/store/worker_workspace_execution.go

@indradhanush indradhanush requested a review from a team January 9, 2023 06:03
@indradhanush

indradhanush commented Jan 9, 2023

Copy link
Copy Markdown
Contributor Author

cc: @adeola-ak

@indradhanush indradhanush merged commit 2c7836c into main Jan 9, 2023
@indradhanush indradhanush deleted the revert-43828-aharvey/add-author-information-on-ssbc branch January 9, 2023 06:14
adeola-ak added a commit that referenced this pull request Jan 12, 2023
@adeola-ak
Revert "Revert "batches: use user name/e-mail with unauthored batch s…
4617067 
…pecs" (#46234)"

This reverts commit 2c7836c.

fixed the E2E executor test that failed after merge
adeola-ak added a commit that referenced this pull request Jan 19, 2023
@adeola-ak
Revert "Revert "batches: use user name/e-mail with unauthored batch s…
a56e175 
…pecs" (#46234)"

This reverts commit 2c7836c.

fixed the E2E executor test that failed after merge
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@burmudar burmudar burmudar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@indradhanush @sourcegraph-bot @burmudar