Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

resendVerificationEmail: do not error if verification email was never sent#46185

Merged
bobheadxi merged 3 commits into
mainfrom
01-05-database/userEmails_do_not_error_if_verification_email_was_never_sent
Jan 6, 2023
Merged

resendVerificationEmail: do not error if verification email was never sent#46185
bobheadxi merged 3 commits into
mainfrom
01-05-database/userEmails_do_not_error_if_verification_email_was_never_sent

Conversation

@bobheadxi

@bobheadxi bobheadxi commented Jan 6, 2023

Copy link
Copy Markdown
Member

Users created with mutation { createUser } that marked their emails as unverified would previously be unable to send verification emails because the button would fail with "email not found".

Test plan

Sign up, mark password as unverified, and "resend verification" now works.

image

@cla-bot cla-bot Bot added the cla-signed label Jan 6, 2023
@bobheadxi

Copy link
Copy Markdown
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@bobheadxi bobheadxi force-pushed the 01-05-database/userEmails_do_not_error_if_verification_email_was_never_sent branch from 16ad89f to 6cd0339 Compare January 6, 2023 00:28
@bobheadxi bobheadxi marked this pull request as ready for review January 6, 2023 01:25
@bobheadxi bobheadxi changed the title database/userEmails: do not error if verification email was never sent resendVerificationEmail: do not error if verification email was never sent Jan 6, 2023

@unknwon unknwon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long-standing paper cuts 😂 thank you!

@bobheadxi bobheadxi merged commit eb9f8b2 into main Jan 6, 2023
@bobheadxi bobheadxi deleted the 01-05-database/userEmails_do_not_error_if_verification_email_was_never_sent branch January 6, 2023 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants