This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Revert "search: fail ListAllIndexed if zoekt is partially available (#45519)"#46123
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff ee72ba3...7310de1.
|
mrnugget
approved these changes
Jan 4, 2023
gl-srgr
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 8135224.
As reported in https://sourcegraph.slack.com/archives/C023ELQLV7F/p1672835804462349.
Currently, Zoekt tries to report in its responses whether or not it has finished the initial load of all of its shards before performing the query. However, there was a bug that caused to still report that it hadn't finished loading even if there were no shards to load. This bug caused this error message to appear on the site admin page:
This revert papers over this issue by restoring the old behavaior (not outright failing the ListAllIndexed call if a crash occurred during the response). After the revert, the site-admin page looks normal again:
The underlying cause in Zoekt was fixed in sourcegraph/zoekt#512. However, for the purposes of a 4.3.1 release I think this change is the smaller one to make to work around the issue (Zoekt has recieved other commits since 4.3.0 release, and I don't want to bring in more changes than we have to).
Test plan
Manual testing:
{ // "GITHUB": [ // { // "url": "https://github.com", // "token": "$REDACTED", // user: sourcegraph-dogfood-user token: dev-private-localdev // "repos": [ // "sourcegraph/sourcegraph", // "hashicorp/go-multierror", // "hashicorp/errwrap", // "sourcegraph-testing/etcd", // "sourcegraph-testing/tidb", // "sourcegraph-testing/titan", // "sourcegraph-testing/zap" // ] // } // ] }