Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Expose corruptedAt and CorruptionLog on Graphql API#45988

Merged
burmudar merged 6 commits into
mainfrom
12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver
Jan 9, 2023
Merged

Expose corruptedAt and CorruptionLog on Graphql API#45988
burmudar merged 6 commits into
mainfrom
12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver

Conversation

@burmudar

@burmudar burmudar commented Dec 28, 2022

Copy link
Copy Markdown
Contributor

Add corruptedAt and corruptionLogs to MirrorInfo so that when
repositories are queried these fields are also fetched

Test plan

CI + unit tests

@cla-bot cla-bot Bot added the cla-signed label Dec 28, 2022
@burmudar Graphite App

burmudar commented Dec 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@burmudar burmudar mentioned this pull request Dec 28, 2022
Merged
2 tasks
@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Dec 28, 2022 •
edited
Loading

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (+0.42 kb) 0.00% (+0.42 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits aaa0881 and 19bb235 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from 25b6580 to 2650466 Compare December 28, 2022 15:25
@burmudar burmudar self-assigned this Dec 28, 2022
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from 2650466 to b59fde0 Compare December 29, 2022 19:48
@burmudar burmudar mentioned this pull request Dec 29, 2022
Merged
1 task
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch 2 times, most recently from a914b43 to 8b3311f Compare December 30, 2022 11:34
@burmudar burmudar changed the base branch from wb/repo/corruption to wb/repo/update-loop-corruption-check December 30, 2022 11:34
@burmudar burmudar mentioned this pull request Dec 30, 2022
Merged
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from 8b3311f to 05543ec Compare December 30, 2022 11:42
@burmudar burmudar marked this pull request as ready for review December 30, 2022 11:47
mrnugget
mrnugget approved these changes Jan 3, 2023
View reviewed changes
Comment thread cmd/frontend/graphqlbackend/schema.graphql Outdated
Comment thread cmd/frontend/graphqlbackend/schema.graphql Outdated
Comment thread cmd/frontend/graphqlbackend/schema.graphql Outdated
Comment thread cmd/frontend/graphqlbackend/repository_mirror.go Outdated
@burmudar burmudar force-pushed the wb/repo/update-loop-corruption-check branch from dede293 to 28c3930 Compare January 3, 2023 15:03
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from 05543ec to c27488b Compare January 3, 2023 15:03
@burmudar burmudar force-pushed the wb/repo/update-loop-corruption-check branch from 28c3930 to 6353553 Compare January 3, 2023 20:43
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from c27488b to 57ef59f Compare January 3, 2023 20:43
@burmudar burmudar force-pushed the wb/repo/update-loop-corruption-check branch from 6353553 to 86bcd25 Compare January 3, 2023 21:21
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from 57ef59f to 24d4d5c Compare January 3, 2023 21:21
@burmudar burmudar force-pushed the wb/repo/update-loop-corruption-check branch from 86bcd25 to 352fe5f Compare January 3, 2023 21:26
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from 24d4d5c to 7c8c0ef Compare January 3, 2023 21:26
@burmudar burmudar force-pushed the wb/repo/update-loop-corruption-check branch from 352fe5f to 159a47c Compare January 3, 2023 21:32
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from 7c8c0ef to a6d62fb Compare January 3, 2023 21:32
@burmudar burmudar force-pushed the wb/repo/update-loop-corruption-check branch from 159a47c to edd03f4 Compare January 3, 2023 22:07
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch 2 times, most recently from 382c2b4 to f1ad1e7 Compare January 3, 2023 22:13
@burmudar burmudar force-pushed the wb/repo/update-loop-corruption-check branch from acf857c to b344086 Compare January 4, 2023 12:09
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from dd66549 to 5db786d Compare January 4, 2023 12:09
@burmudar burmudar force-pushed the wb/repo/update-loop-corruption-check branch from b344086 to fbcdd3b Compare January 4, 2023 17:17
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from d593c67 to c001166 Compare January 4, 2023 17:17
@burmudar burmudar force-pushed the wb/repo/update-loop-corruption-check branch from fbcdd3b to eeaf8a1 Compare January 9, 2023 10:59
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from c001166 to bb35880 Compare January 9, 2023 11:00
@burmudar burmudar force-pushed the wb/repo/update-loop-corruption-check branch from eeaf8a1 to 38c83ac Compare January 9, 2023 13:12
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from bb35880 to ad45b26 Compare January 9, 2023 13:12
@burmudar burmudar force-pushed the wb/repo/update-loop-corruption-check branch from 38c83ac to bcbd8b1 Compare January 9, 2023 14:45
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from ad45b26 to 185c8e1 Compare January 9, 2023 14:45
@burmudar Graphite App

burmudar commented Jan 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

⏳ This pull request is set to merge as part of a Graphite merge job
Stack job ID: hSUUYP6wzZj7kdyI1hms.
See details on graphite.dev

Base automatically changed from wb/repo/update-loop-corruption-check to main January 9, 2023 15:27
burmudar and others added 6 commits January 9, 2023 17:31
@burmudar
add corruptedAt and corruption log to MirrorInfo resolver
919fde2
@burmudar
expose corruptionLogs and corruptedAt on grapql
bcebdec 
* add corruptionAt field to mirrorInfo
* add corruptionLogResolver
* fetch corruption details for settings area
@burmudar @mrnugget
Update cmd/frontend/graphqlbackend/schema.graphql
b0b37c6 
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
@burmudar @mrnugget
Update cmd/frontend/graphqlbackend/schema.graphql
7ea430f 
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
@burmudar
review feedback
6ab63cc 
- corruptedAt -> isCorruptedAt
- make corruptionLogs values not optional
@burmudar
mark fields in array as not optional
aaa0881
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from 185c8e1 to aaa0881 Compare January 9, 2023 15:34
@burmudar burmudar merged commit d3a798c into main Jan 9, 2023
@burmudar burmudar deleted the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch January 9, 2023 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sashaostrikov sashaostrikov Awaiting requested review from sashaostrikov

@eseliger eseliger Awaiting requested review from eseliger

1 more reviewer

@mrnugget mrnugget mrnugget approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@burmudar burmudar

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@burmudar @sg-e2e-regression-test-bob @mrnugget