Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

insights: adds live preview for strat insights#45910

Merged
chwarwick merged 5 commits into
vk/new-insight-repo-uifrom
cw/live-preview-strat
Dec 22, 2022
Merged

insights: adds live preview for strat insights#45910
chwarwick merged 5 commits into
vk/new-insight-repo-uifrom
cw/live-preview-strat

Conversation

@chwarwick

@chwarwick chwarwick commented Dec 21, 2022

Copy link
Copy Markdown
Contributor

Adds live preview for insights that define repos using a search query

Test plan

Manual check of live preview for each insight type
Manual check of live preview used on getting started page

App preview:

Check out the client app preview documentation to learn more.

@sg-e2e-regression-test-bob

sg-e2e-regression-test-bob commented Dec 21, 2022

Copy link
Copy Markdown

Bundle size report 📦

Initial size Total size Async size Modules
0.02% (+0.69 kb) 0.07% (+9.72 kb) 0.08% (+9.02 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 7b76ee6 and 6073d5c or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@chwarwick chwarwick merged commit a17bdfa into vk/new-insight-repo-ui Dec 22, 2022
@chwarwick chwarwick deleted the cw/live-preview-strat branch December 22, 2022 13:18
@vovakulikov

Copy link
Copy Markdown
Contributor

@chwarwick I think that we forgot about the additional screen for the live preview when we have more than 20 repos to preview. In this case, we should have an error or blur screen with a message that we tried to run a preview but got too many repos to provide a proper preview

@chwarwick

Copy link
Copy Markdown
Contributor Author

@chwarwick I think that we forgot about the additional screen for the live preview when we have more than 20 repos to preview. In this case, we should have an error or blur screen with a message that we tried to run a preview but got too many repos to provide a proper preview

There's a separate screen for that? I just had the api return an error.

@vovakulikov

Copy link
Copy Markdown
Contributor

@chwarwick In original Alicja designs there was a special live preview card state for it

Screenshot 2022-12-22 at 11 04 57

@vovakulikov

Copy link
Copy Markdown
Contributor

I can add this handling later in my PR but just FYI that we have a special state for this type of error. Maybe it would be better if we had a union type in live preview results in the API.

vovakulikov added a commit that referenced this pull request Jan 24, 2023
* Split Input.tsx component into small UI component blocks

* Refactor monaco field in order to support codemirror queryState integration

* Add new repo section to the creation UI form

* Add repo section UI

* Add two field mode for the repo section setting

* Force aria-invalid to the field component

* Adjust useField/useForm validation (focus first invalid field logic)

* Add aria invalid prop to the monaco UI field

* Fix insight query input codemirror logic

* Remove old version of insight repo section UI

* Connect repo UI to the search-based creation UI

* Extract repo fields logic to the separate helper

* Fix focus problems with disabled repo sections

* Fix 1 click creation flow

* Fix edit UI for the search-based insight

* Make insight repo section sharable components

* Add new repo UI to the capture group insight

* Fix potential problems with TS over input types and props

* Fix insight templates parsers

* Fix a few types problem more...

* Fix parser unit tests

* Add new inputs to the create/update gql handlers

* Fix eslint and unit test problems

* Fix integration tests

* Fix disabled/hide value states

* Fix problems with live preview layout

* Fix problem with autosuggestion for the repo query field

* Fix problems with bad repoquery and repositories values for the create mutation

* Fix copies

* Add async query syntax validation to the repo query field

* Add repositories count UI

* Fix by UI review comments

* insights: adds live preview for strat insights (#45910)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants