This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: Filtering by context should OR together multiple repos #45574
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 1d14e5e...33050f2.
|
leonore
approved these changes
Dec 13, 2022
Co-authored-by: leo <leo.p@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When filtering an insight by a search context that contains multiple repos, the generated sql was combining the repo name conditions with an
ANDwhich was excluding all of the data.This does not effect the exclude repos case which should continue to use an
ANDcondition.closes https://github.com/sourcegraph/sourcegraph/issues/45032
Test plan
Create a search context with two repo filters
Generate an insight over those repos
Filter the insight by the search context - all data should remain
Edit the context to only be 1 repo - filtered insight should show 1 repo of data