This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Codemirror blob: enable dy default#45514
Merged
Merged
Conversation
Contributor
|
@taras-yemets What's the status on this PR? |
Contributor
Author
Now the CodeMirror blob view is enabled for Sourcegraph org users on dotcom. We are going to enable it by default in the next release if there are no outstanding blockers. |
Contributor
|
@taras-yemets Makes sense! I vividly remembered that we already shipped this so I got confused 😅 |
Comment on lines
+47
to
+53
| ...createViewerSettingsGraphQLOverride({ | ||
| user: { | ||
| experimentalFeatures: { | ||
| enableCodeMirrorFileView: false, | ||
| }, | ||
| }, | ||
| }), |
Contributor
There was a problem hiding this comment.
We should instead fix the tests to work with CodeMirror 😅
Contributor
Author
There was a problem hiding this comment.
We have a similar test for the CodeMirror blob viewer.
burmudar
added a commit
that referenced
this pull request
Feb 13, 2023
This reverts commit 7f3532c. ## Test plan None - this is a revert <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
taras-yemets
added a commit
that referenced
this pull request
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables CodeMirror blob view by default.
Test plan
CI passes
App preview:
Check out the client app preview documentation to learn more.