This repository was archived by the owner on Sep 30, 2024. It is now read-only.
codeintel: Register SCIP oobmigration#45106
Merged
Merged
Conversation
1 task
Contributor
Author
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 1e086b8...52e991e.
|
09ab552 to
cf71482
Compare
This was referenced Jan 4, 2023
cesrjimenez
approved these changes
Jan 6, 2023
8e0f4d9 to
c0da6b1
Compare
facebd8 to
faed4e4
Compare
efritz
commented
Jan 13, 2023
efritz
commented
Jan 13, 2023
efritz
commented
Jan 13, 2023
efritz
commented
Jan 13, 2023
efritz
commented
Jan 13, 2023
Strum355
approved these changes
Jan 19, 2023
| ### Added | ||
|
|
||
| - | ||
| - Added out-of-band migration that will migrate all existing data from LSIF to SCIP (see additional [migration documentation](https://docs.sourcegraph.com/admin/how-to/lsif_scip_migration)). [#45106](https://github.com/sourcegraph/sourcegraph/pull/45106) |
Contributor
There was a problem hiding this comment.
should we add the big warning here too? People mightnt click these links
Contributor
Author
There was a problem hiding this comment.
cc @coury-clark
Thoughts on how much attention to bring to changelog notices like these?
Contributor
There was a problem hiding this comment.
If this is something that every admin needs to read, I'd suggest highlighting this with something like Important:, and adding it to the release post sourcegraph/about#5951
Contributor
Author
There was a problem hiding this comment.
I can write more in the 4.5 release post.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR registers the migration introduced in the linked PR.
Fixes #45087.
Test plan
main-dry-run