This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: fix fork naming for gitlab#44458
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff f34562d...ad3a876.
|
LawnGnome
approved these changes
Nov 26, 2022
LawnGnome
left a comment
Contributor
There was a problem hiding this comment.
One question about the exact signature of ForkProject, but otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #44456
This PR is to match the behavior and naming convention first implemented for bitbucket server (#43681) which will add the original namespace to the repo name when creating the fork on the codehost (gitlab) and fork to usernamespace/originalnamespace-reponame as well as update the path
Test plan
manually tested the creation of forks with enforce forks setting on