This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: oob migration for saving recording times for existing insights#44165
Merged
Conversation
added 13 commits
November 7, 2022 10:50
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff ef37174...b3878a8.
|
Contributor
|
I think this looks good, but I think we also need an noop migrator that reports 100% if insights is disabled. |
coury-clark
suggested changes
Nov 10, 2022
| series[id] = seriesMetadata{ | ||
| id: id, | ||
| createdAt: createdAt, | ||
| lastRecordedAt: lastRecordedAt, |
Contributor
There was a problem hiding this comment.
Just talking out loud:
If a record is currently queued when this runs, we should be fine because the new recording time will be written whenever that job executes.
chwarwick
reviewed
Nov 14, 2022
coury-clark
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #43496
heuristic for using existing recording_times rather than generated ones is + half an interval (quarter of for hourly insights)
Test plan
Added unit tests for migrator and helpers
Tested manually on existing insights by setting supports_augmentation = FALSE and deleting all existing recording times, running the oob migration and validating that insights still look good