This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Fix CSS injection of Phabricator native extension#43868
Merged
Conversation
Contributor
Author
|
Added some docs as well to the browser extensions README so that we have an easier time reproducing this the next time 🙂 |
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits fb9ce67 and c8ca297 or learn more. Open explanation
|
Contributor
Author
|
Apparently this is the expected styling, this is from the browser extension:
|
philipp-spiess
added a commit
that referenced
this pull request
Nov 8, 2022
philipp-spiess
added a commit
that referenced
this pull request
Nov 8, 2022
11 tasks
philipp-spiess
added a commit
that referenced
this pull request
Nov 8, 2022
philipp-spiess
added a commit
that referenced
this pull request
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42555
The Phabricator native extension injected the same CSS file twice instead of injecting both
style.bundle.cssandinject.bundle.css😐.Once the PR is merged, this will require waiting for a new Sourcegraph release.
Other issues
The hover menu looks a bit gross, I'll verify how it is supposed to look in our browser extension before merging this PR.
Test plan
App preview:
Check out the client app preview documentation to learn more.