This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Fix cache policy for search exports query#43344
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 30b15a0...b30670b.
|
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits b30670b and fc19858 or learn more. Open explanation
|
vdavid
approved these changes
Oct 24, 2022
vdavid
left a comment
Contributor
There was a problem hiding this comment.
Looks good! My first thought was to see how disabling caching affects performance, but this is a feature that's not likely to be called twice, so this seems to be a fine solution. (I also saw that we use fetchPolicy: 'no-cache' at many places in the code base.)
11 tasks
philipp-spiess
added a commit
that referenced
this pull request
Nov 8, 2022
philipp-spiess
added a commit
that referenced
this pull request
Nov 8, 2022
philipp-spiess
added a commit
that referenced
this pull request
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43222
Apparently, the default cache setup in Apollo can lead to properties being garbage collected before the onCompleted callback is invoked.
I have to investigate further to understand what exactly is going on but the symptom was that Apollo has removed fields from the resulting objects before the search export logic was able to read those values.
Thanks to @umpox for providing the hint regarding this having to do with the fetch policy.
Test plan
I verified locally that exporting search results indeed works again.
test.plan.mov
App preview:
Check out the client app preview documentation to learn more.