This repository was archived by the owner on Sep 30, 2024. It is now read-only.
admin: Display repo sync counters per sync job#43039
Merged
Merged
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 646afbe and d833098 or learn more. Open explanation
|
mrnugget
approved these changes
Oct 17, 2022
sashaostrikov
approved these changes
Oct 17, 2022
sashaostrikov
left a comment
Contributor
There was a problem hiding this comment.
Let's gooooooo! 
(I'd engage designers just in case, but to my preference this looks awesome!)
pjlast
reviewed
Oct 18, 2022
Comment on lines
+315
to
+320
| reposSynced | ||
| repoSyncErrors | ||
| reposAdded | ||
| reposDeleted | ||
| reposModified | ||
| reposUnmodified |
Contributor
There was a problem hiding this comment.
You need to update client/web/src/components/externalServices/ExternalServicePage.story.tsx , line 54, to contain these fields as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose sync counters in the UI per external service sync job.
Here's a short demo:
sync-counters.mov
Closes https://github.com/sourcegraph/sourcegraph/issues/42868
Thanks @sashaostrikov for the help figuring out how to get the
ValueLegendListcomponent integrated.Test plan
Tested locally, see video above