This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: add ability to filter count and list of BatchSpecs by empty specs#42914
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 21c49c8...76629e9.
|
courier-new
approved these changes
Oct 13, 2022
courier-new
left a comment
Contributor
There was a problem hiding this comment.
Looks awesome, and thanks for adding tests for this!
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
Contributor
|
Do you mind adding an item to the |
Piszmog
approved these changes
Oct 18, 2022
BolajiOlajide
approved these changes
Oct 18, 2022
eseliger
approved these changes
Oct 18, 2022
|
|
||
| if opts.ExcludeEmptySpecs { | ||
| // An empty batch spec's YAML only contains the name, so we filter to batch specs that have at least one key other than "name" | ||
| preds = append(preds, sqlf.Sprintf("(EXISTS (SELECT * FROM jsonb_object_keys(batch_specs.spec) AS t (k) WHERE t.k NOT LIKE 'name'))")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #38610
Add filter by empty batch spec option (
ExcludeEmptySpecs) to batchSpec schema and update BatchSpecPage query in order to prevent empty batch specs from appearing in the list of executions of a batch change as well as the list of executions on the admin page. Decided to filter out empty batch specs by querying specs with at least 1 field other than name.prior to fix, with execution spec list including the initiated empty batch spec
after fix, with execution spec list excluding the initiated empty batch spec
Test plan
added tests to confirm filter works as well as visually able to see the specs are no longer present