Use temporary settings to track configurable "time saved" analytics fields#42785
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff a104ee6...bf91e92.
|
|
I think temporary settings are per user, correct? Since only the site admin can access the page where it's set, how do regular users get any useful number on the BC list page? Maybe a design question more than a code question, actually. |
* set up backend with new changesets api * display data * add changeset status cells * fix margin and go linting * add tooltip * missed migration? * remove important * lower case c * remove space * loading and error state * remove label as its optional * replace changeset connection with global stats * save time save in local storage remove label * add tests * uncomment tests * go fix * fix stitched migration * remove space from s.mig * fix error and loading * fix error handle * error handling * case for no data * remove error import * add story * fix BatchChangeListPage broke story * revert label * add constant per item saved key variable * Changesets merged Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com> * Hours saved Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com> * closed Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com> * open Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com> * feedback * resolve comments * Update cmd/frontend/graphqlbackend/batches.graphql Co-authored-by: Erik Seliger <erikseliger@me.com> * fixes * add test * uncomment tests * Use temporary settings to track configurable "time saved" analytics fields (#42785) * fix changeset cells * remove null state Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com> Co-authored-by: Erik Seliger <erikseliger@me.com>
|
It's true, I feel like the calculation value part of this was under-spec'd in the ticket because we all assumed this was already saved somewhere. 😂 But hey, saving for admins is still better than not saving at all, right? Regular users will just get the default 15 minutes. Maybe we can file a follow-up ticket about saving this site-wide somehow. |
I think that would be great :) |
Screen.Recording.2022-10-10.at.5.18.34.PM.mov
Test plan
Tested locally. Observed updated temporary settings in the database.