This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: display kpis on list page#42046
Merged
Merged
Conversation
44c463c to
8459344
Compare
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff a2a2945...26df071.
|
eseliger
reviewed
Sep 27, 2022
courier-new
reviewed
Oct 6, 2022
courier-new
left a comment
Contributor
There was a problem hiding this comment.
Looking good so far! Left a couple notes -- mostly I'd love to see a Storybook story for this!
I also think the Batch Change List Page story is going to need an additional mock response for the global stats query.
courier-new
reviewed
Oct 7, 2022
courier-new
reviewed
Oct 7, 2022
Contributor
There was a problem hiding this comment.
Did a quick design review as well, just had a couple small suggestions! I also have two questions that I'd be curious to hear your thoughts about, or @danielmarquespt!
I don't know about you but I also find the bolding of the numbers in the right set of stats weird, considering they're right above a bunch of changeset stats that aren't bold:
Should we drop the boldness?
I also saw in the original designs, the icons were gray:
I also don't know how I feel about that, considering they're colored everywhere else. Do we want to keep them colored, like you did in your implementation?
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
courier-new
reviewed
Oct 10, 2022
courier-new
reviewed
Oct 10, 2022
eseliger
reviewed
Oct 10, 2022
Co-authored-by: Erik Seliger <erikseliger@me.com>
courier-new
approved these changes
Oct 11, 2022
courier-new
left a comment
Contributor
There was a problem hiding this comment.
Fantastic work, it looks really good. 🙂 Approving to unblock merge, so you can demo it tomorrow!! 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37750
Adds the kpi dashboard for the batch changes list page. Omitted the merged icon that was included in the figma as it seemed a little redundant.
Test plan
visually tested