This repository was archived by the owner on Sep 30, 2024. It is now read-only.
authz: store all Perforce protect rules in paths column of sub_repo_permissions table.#41859
Merged
sashaostrikov merged 2 commits intoSep 22, 2022
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 26713ac...2005ef5.
|
Contributor
|
Going to link to this comment here: https://github.com/sourcegraph/sourcegraph/pull/41785#discussion_r976464966 |
ryanslade
reviewed
Sep 21, 2022
Contributor
There was a problem hiding this comment.
Do we need formattedExcludes? Can't we just append to srp.Paths in the for loop?
ryanslade
reviewed
Sep 21, 2022
Contributor
There was a problem hiding this comment.
Can you add tests that confirm we're writing the paths please :)
ryanslade
reviewed
Sep 21, 2022
Contributor
There was a problem hiding this comment.
Can you add tests that confirm we're writing the paths please :)
…o_permissions` table. This is the first part of Perforce rules matching simplification. The idea is that all rules are stored as is and read one-by-one during matching (vs. previous approach of "merging" the rules before storing them in the DB). Test plan: Unit tests updated. Existing related tests should not fail.
d1a7f9b to
2005ef5
Compare
sashaostrikov
added a commit
that referenced
this pull request
Sep 29, 2022
…o_permissions` table. (#41859) This is the first part of Perforce rules matching simplification. The idea is that all rules are stored as is and read one-by-one during matching (vs. previous approach of "merging" the rules before storing them in the DB). Test plan: Unit tests updated. Existing related tests should not fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of Perforce rules matching simplification. The idea is that all rules are stored as is and read one-by-one during matching (vs. previous approach of "merging" the rules before storing them in the DB).
Test plan:
Unit tests updated. Existing related tests should not fail.
Depends on and should be merged after https://github.com/sourcegraph/sourcegraph/pull/41785
Closes https://github.com/sourcegraph/sourcegraph/issues/41789