This repository was archived by the owner on Sep 30, 2024. It is now read-only.
otlp: treat OTEL_EXPORTER_OTLP_ENDPOINT='' as OpenTelemetry being disabled#41243
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff af067ef...d02df75.
|
13 tasks
sanderginn
approved these changes
Sep 2, 2022
jhchabran
approved these changes
Sep 2, 2022
bobheadxi
added a commit
that referenced
this pull request
Sep 2, 2022
With jaeger no longer being the default tracing mechanism (#41242), this change removes jaeger from sourcegraph/server - it is disrecommended for production use, so I think this is probably fine - and also disables OpenTelemetry (#41243) in sourcegraph/server so we don't have to figure out an OpenTelemetry deployment for it (again, this image is not recommended for production use so I don't think we need to introduce advanced capabilities like OpenTelemetry out-of-the-box for it (there is some precedent for this - cAdvisor, for example, is not included in sourcegraph/server). Users can still configure an exporter with OTEL_EXPORTER_OTLP_ENDPOINT. Co-authored-by: Sander Ginn <sander@ginn.it>
efritz
pushed a commit
that referenced
this pull request
Sep 6, 2022
With jaeger no longer being the default tracing mechanism (#41242), this change removes jaeger from sourcegraph/server - it is disrecommended for production use, so I think this is probably fine - and also disables OpenTelemetry (#41243) in sourcegraph/server so we don't have to figure out an OpenTelemetry deployment for it (again, this image is not recommended for production use so I don't think we need to introduce advanced capabilities like OpenTelemetry out-of-the-box for it (there is some precedent for this - cAdvisor, for example, is not included in sourcegraph/server). Users can still configure an exporter with OTEL_EXPORTER_OTLP_ENDPOINT. Co-authored-by: Sander Ginn <sander@ginn.it>
efritz
pushed a commit
that referenced
this pull request
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need a mechanism to disable OpenTelemetry by default even if it is enabled by default (#41242), most notably for
sourcegraph/server(https://github.com/sourcegraph/sourcegraph/pull/41244)Test plan
OTEL_EXPORTER_OTLP_ENDPOINT='' sg start