Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

search ui: permanently enable simple ui (but keep temp setting)#41021

Merged
limitedmage merged 12 commits into
mainfrom
jp/enablesimpleui
Sep 2, 2022
Merged

search ui: permanently enable simple ui (but keep temp setting)#41021
limitedmage merged 12 commits into
mainfrom
jp/enablesimpleui

Conversation

@limitedmage

@limitedmage limitedmage commented Aug 29, 2022 •
edited by sourcegraph-bot
Loading

Copy link
Copy Markdown
Contributor

Closes https://github.com/sourcegraph/sourcegraph/issues/41001

  • Set the Simple UI feature flag to be on by default.
  • Remove the toggle, keep the temporary setting.
  • Flip search history feature flag, so that it is off by default and the feature flag enables it.

Test plan

  • Chromatic Storybook has been updated so that all stories have Simple UI enabled. Some irrelevant stories (eg. homepage panels) have been removed, and some new stories have been added to test the new UI (eg. server home with chips).
  • Updated unit tests to be based on the new UI.
  • Verify updated Storybook and Percy snapshots.
  • Verify that users without any temp settings get the new UI by clearing the temporary settings.
  • Verify that users who have previously turned off Simple UI via toggle get the new UI anyway.
  • Verify that the search history is off by default and only shown if feature flag search-input-show-history is enabled.

App preview:

Check out the client app preview documentation to learn more.

@cla-bot cla-bot Bot added the cla-signed label Aug 29, 2022
@sourcegraph-bot

sourcegraph-bot commented Aug 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff c43bcc0...5324eb4.

Notify File(s)
@fkling client/search-ui/src/components/ResultContainer.tsx
client/search-ui/src/results/progress/StreamingProgress.story.tsx
client/search-ui/src/results/progress/StreamingProgressSkippedButton.test.tsx
client/search-ui/src/results/progress/snapshots/StreamingProgressSkippedPopover.test.tsx.snap
client/search-ui/src/results/sidebar/SidebarButtonStrip.tsx
client/shared/src/search/stream.ts
client/web/src/search/home/SearchPage.story.tsx
client/web/src/search/home/SearchPageInput.tsx
client/web/src/search/results/StreamingSearchResults.story.tsx
client/web/src/search/results/StreamingSearchResults.test.tsx
client/web/src/search/results/snapshots/SearchResultsInfoBar.test.tsx.snap

@limitedmage limitedmage requested a review from a team August 30, 2022 16:42
rvantonder
rvantonder approved these changes Sep 1, 2022
View reviewed changes

@rvantonder rvantonder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@limitedmage limitedmage merged commit e84daee into main Sep 2, 2022
@limitedmage limitedmage deleted the jp/enablesimpleui branch September 2, 2022 22:53
efritz pushed a commit that referenced this pull request Sep 6, 2022
@limitedmage @efritz
search ui: permanently enable simple ui (but keep temp setting) (#41021)
6c48d7b 
* changes

* update changelog

* fix unit tests

* fix ts build

* rename temp setting so users that have turned it off get the new UI

* fix broken merge

* remove unneeded stories and add stories for new UI

* fix test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rvantonder rvantonder rvantonder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable Simple UI by default

3 participants

@limitedmage @sourcegraph-bot @rvantonder