batches: issue executor warning when outdated by BolajiOlajide · Pull Request #40916 · sourcegraph/sourcegraph-public-snapshot

BolajiOlajide · 2022-08-26T13:13:08Z

Closes #27570

Test plan

Confirm warning only shows up on active executors that have a version lower than the sourcegraph version (either using semver versioning or timestamps).

App preview:

Check out the client app preview documentation to learn more.

BolajiOlajide · 2022-08-26T15:03:23Z

@danielmarquespt Is the wording for this alert okay?

sourcegraph-bot · 2022-08-26T15:04:53Z

Codenotify: Notifying subscribers in CODENOTIFY files for diff c7c01c8...1e747c2.

Notify	File(s)
@courier-new	client/web/src/enterprise/batches/batch-spec/batch-spec.mock.ts client/web/src/enterprise/batches/batch-spec/execute/backend.ts
@efritz	client/web/src/enterprise/executors/ExecutorsListPage.tsx client/web/src/enterprise/executors/useExecutors.tsx
@eseliger	client/web/src/enterprise/batches/batch-spec/batch-spec.mock.ts client/web/src/enterprise/batches/batch-spec/execute/backend.ts client/web/src/enterprise/executors/ExecutorsListPage.tsx client/web/src/enterprise/executors/useExecutors.tsx

danielmarquespt · 2022-08-26T15:29:14Z

@danielmarquespt Is the wording for this alert okay?

@BolajiOlajide Are able to tell the user which version would be a compatible version?

BolajiOlajide · 2022-08-26T15:30:39Z

@danielmarquespt Is the wording for this alert okay?

@BolajiOlajide Are able to tell the user which version would be a compatible version?

Yes.

danielmarquespt · 2022-08-26T15:37:02Z

@danielmarquespt Is the wording for this alert okay?

@BolajiOlajide Are able to tell the user which version would be a compatible version?

Yes.

Then I would suggest something like "Please upgrade this executor to a version compatible with your Sourcegraph installation (X.X or higher)"

eseliger

sorry for the slow review! Added a few questions inline

LawnGnome

👍

eseliger

Pending Adams comments, LGTM!

Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>

…r.go Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>

Co-authored-by: Erik Seliger <erikseliger@me.com>

* display warning for outdated executors * format * format error message * move method for checking executor version to its own module * prettier * update comment * update warning text * prettier * prettier * display spinner when fetching sourcegraph version * move the logic to backend * move logic to backend * rewrite implementation * add tests for resolver * Update cmd/frontend/graphqlbackend/schema.graphql Co-authored-by: Erik Seliger <erikseliger@me.com> * update changelog * appropriately compare dates * allow executor version to be one minor version behind * fix ts build error * Update CHANGELOG.md Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com> * Update internal/services/executors/transport/graphql/executor_resolver.go Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com> * clean up executor resolver * add upgrade executors link * rewrite logic for calculating executor compatibility * update UI * use /help instead of https://docs.sourcegraph.com * rename TOONEW to VERSION_AHEAD * Update executor_resolver.go * Update cmd/frontend/graphqlbackend/schema.graphql Co-authored-by: Erik Seliger <erikseliger@me.com> * Update cmd/frontend/graphqlbackend/schema.graphql Co-authored-by: Erik Seliger <erikseliger@me.com> * Update client/web/src/enterprise/executors/ExecutorsListPage.tsx Co-authored-by: Erik Seliger <erikseliger@me.com> * Update cmd/frontend/graphqlbackend/schema.graphql Co-authored-by: Erik Seliger <erikseliger@me.com> * Update cmd/frontend/graphqlbackend/schema.graphql Co-authored-by: Erik Seliger <erikseliger@me.com> * Update cmd/frontend/graphqlbackend/schema.graphql Co-authored-by: Erik Seliger <erikseliger@me.com> * cleanup * more cleanup * fix ts build error * handle more edge cases * update changelog * implement feedback * update schema docstring * update name in test Co-authored-by: Erik Seliger <erikseliger@me.com> Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>

BolajiOlajide added the batch-changes Issues related to Batch Changes label Aug 26, 2022

BolajiOlajide self-assigned this Aug 26, 2022

cla-bot Bot added the cla-signed label Aug 26, 2022

BolajiOlajide marked this pull request as ready for review August 26, 2022 15:03

BolajiOlajide requested a review from a team August 26, 2022 15:03

eseliger reviewed Aug 29, 2022

View reviewed changes

Comment thread client/web/src/enterprise/batches/batch-spec/execute/TimelineModal.tsx Outdated

Comment thread client/web/src/enterprise/executors/utils.ts Outdated

BolajiOlajide force-pushed the bo/outdated-executor-warning branch from a266d89 to 16870d5 Compare September 2, 2022 17:08

BolajiOlajide requested review from courier-new and eseliger September 2, 2022 17:11

eseliger approved these changes Sep 5, 2022

View reviewed changes

BolajiOlajide force-pushed the bo/outdated-executor-warning branch from 7750c5d to 69f4358 Compare September 5, 2022 17:14

courier-new approved these changes Sep 5, 2022

View reviewed changes

Piszmog approved these changes Sep 6, 2022

View reviewed changes

Comment thread cmd/frontend/graphqlbackend/schema.graphql Outdated

BolajiOlajide force-pushed the bo/outdated-executor-warning branch from 15ebc58 to 4f3daf4 Compare September 9, 2022 13:09

BolajiOlajide commented Sep 9, 2022

View reviewed changes

Comment thread cmd/frontend/graphqlbackend/schema.graphql Outdated

Comment thread internal/services/executors/transport/graphql/executor_resolver.go Outdated

BolajiOlajide force-pushed the bo/outdated-executor-warning branch from 87b2c9a to a93c614 Compare September 13, 2022 13:39

Piszmog approved these changes Sep 15, 2022

View reviewed changes

Comment thread internal/services/executors/transport/graphql/executor_resolver.go Outdated

eseliger reviewed Sep 19, 2022

View reviewed changes

BolajiOlajide force-pushed the bo/outdated-executor-warning branch 2 times, most recently from 3479219 to 7d6418c Compare September 21, 2022 23:51

LawnGnome approved these changes Sep 22, 2022

View reviewed changes

Comment thread internal/services/executors/transport/graphql/executor_resolver.go Outdated

Comment thread cmd/frontend/graphqlbackend/schema.graphql Outdated

Comment thread internal/services/executors/transport/graphql/executor_resolver.go Outdated

eseliger approved these changes Sep 22, 2022

View reviewed changes

BolajiOlajide commented Sep 22, 2022

View reviewed changes

Comment thread client/shared/src/commandPalette/CommandList.tsx Outdated

Comment thread client/web/src/org/members/SearchUserAutocomplete.tsx Outdated

Comment thread client/shared/src/commandPalette/CommandList.tsx Outdated

BolajiOlajide added 2 commits September 22, 2022 19:21

display warning for outdated executors

404be6b

format

5ada8a7

BolajiOlajide and others added 25 commits September 22, 2022 19:21

appropriately compare dates

114dad1

allow executor version to be one minor version behind

dfbc5cf

fix ts build error

0229332

Update CHANGELOG.md

177e388

Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>

Update internal/services/executors/transport/graphql/executor_resolve…

f46655d

…r.go Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>

clean up executor resolver

4654f27

add upgrade executors link

280f00b

rewrite logic for calculating executor compatibility

2a85ab3

update UI

48b0b1d

use /help instead of https://docs.sourcegraph.com

4e1c291

rename TOONEW to VERSION_AHEAD

1b11df5

Update executor_resolver.go

a487464

Update cmd/frontend/graphqlbackend/schema.graphql

dbd5a0a

Co-authored-by: Erik Seliger <erikseliger@me.com>

Update cmd/frontend/graphqlbackend/schema.graphql

cc34aee

Co-authored-by: Erik Seliger <erikseliger@me.com>

Update client/web/src/enterprise/executors/ExecutorsListPage.tsx

b52d883

Co-authored-by: Erik Seliger <erikseliger@me.com>

Update cmd/frontend/graphqlbackend/schema.graphql

73251f8

Co-authored-by: Erik Seliger <erikseliger@me.com>

Update cmd/frontend/graphqlbackend/schema.graphql

a00d1bb

Co-authored-by: Erik Seliger <erikseliger@me.com>

Update cmd/frontend/graphqlbackend/schema.graphql

5c28300

Co-authored-by: Erik Seliger <erikseliger@me.com>

cleanup

c75fbbc

more cleanup

e627b9a

fix ts build error

a942f97

handle more edge cases

880592d

update changelog

5d005bc

implement feedback

eacdd36

update schema docstring

167614a

BolajiOlajide force-pushed the bo/outdated-executor-warning branch from 3723bb2 to 167614a Compare September 22, 2022 18:25

update name in test

1e747c2

BolajiOlajide merged commit 7c35851 into main Sep 22, 2022

BolajiOlajide deleted the bo/outdated-executor-warning branch September 22, 2022 18:57

Conversation

BolajiOlajide commented Aug 26, 2022 • edited by sourcegraph-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test plan

App preview:

Uh oh!

BolajiOlajide commented Aug 26, 2022

Uh oh!

sourcegraph-bot commented Aug 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielmarquespt commented Aug 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BolajiOlajide commented Aug 26, 2022

Uh oh!

danielmarquespt commented Aug 26, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eseliger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LawnGnome left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eseliger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

BolajiOlajide commented Aug 26, 2022 •

edited by sourcegraph-bot

Loading

sourcegraph-bot commented Aug 26, 2022 •

edited

Loading

danielmarquespt commented Aug 26, 2022 •

edited

Loading