This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Search backend: allow repo:contains in global searches#40239
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 10a9ad6...f062cde.
|
rvantonder
approved these changes
Aug 12, 2022
25596b0 to
f062cde
Compare
jdorfman
pushed a commit
that referenced
this pull request
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates our global search and zoekt logic to allow
repo:contains.file()andrepo:contains.content()in global searches.This is a followup from @keegancsmith's comment. Basically, it makes these searches way faster when the only
repo:filters arerepo:contains.file()orrepo:contains.content()because we don't have to paginate through all the repos 4k at a time. I didn't do this at the time because I was just trying to untangle concerns, but this turns out to be a fairly minimal change.Stacked on #40236
Related to https://github.com/sourcegraph/sourcegraph/issues/39392
Test plan
Backend integration tests + manual smoke testing