This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gqltest: add failure message when Bitbucket Permissions job failed to run#39428
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff fea76e9...c5ec13e.
|
ryanslade
reviewed
Jul 26, 2022
| return "", "", nil | ||
| } else { | ||
| return resp.Data.Jobs.Nodes[0].State, nil | ||
| return resp.Data.Jobs.Nodes[0].State, resp.Data.Jobs.Nodes[0].FailureMessage, nil |
Contributor
There was a problem hiding this comment.
In what cases can we get more than one here?
Could extract resp.Data.Jobs.Nodes[0] to a var to improve readability
Contributor
Author
There was a problem hiding this comment.
in tests only if we invoke the API and schedule the job more than once
+1 for extraction, will do it now
| // GetLastBitbucketProjectPermissionJob returns a status of the most recent | ||
| // BitbucketProjectPermissionJob for given projectKey | ||
| func (c *Client) GetLastBitbucketProjectPermissionJob(projectKey string) (string, error) { | ||
| func (c *Client) GetLastBitbucketProjectPermissionJob(projectKey string) (string, string, error) { |
Contributor
There was a problem hiding this comment.
would it make sense to add names on these returns, just so that its more obvious what the two different strings are?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add clarity to understanding the root cause of a failure.
Test plan
Existing tests should pass