Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

frontend: Remove unused inventory routes#39373

Merged
ryanslade merged 1 commit into
mainfrom
rs/remove-inventory-routes
Jul 25, 2022
Merged

frontend: Remove unused inventory routes#39373
ryanslade merged 1 commit into
mainfrom
rs/remove-inventory-routes

Conversation

@ryanslade

@ryanslade ryanslade commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

Instrumentation showed that these endpoints aren't being used and it
looks like there weren't even any handlers attached to the routes.

Part of https://github.com/sourcegraph/sourcegraph/issues/36290

Test plan

Dead code, tests should pass

Instrumentation showed that these endpoints aren't being used and it
looks like there weren't even any handlers attached to the routes.
@cla-bot cla-bot Bot added the cla-signed label Jul 25, 2022
@ryanslade ryanslade marked this pull request as ready for review July 25, 2022 15:15
@ryanslade ryanslade requested a review from a team July 25, 2022 15:15
@ryanslade ryanslade changed the title frontend: Remove unused routes frontend: Remove unused inventory routes Jul 25, 2022

@sashaostrikov sashaostrikov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ryanslade

Copy link
Copy Markdown
Contributor Author

Confirmed that these handlers were removed a long time ago:
https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph/-/commit/8572e643fa4a0a024a4be7d2441a45649800368f

Diff search for the win!

@ryanslade ryanslade merged commit d3ed3b4 into main Jul 25, 2022
@ryanslade ryanslade deleted the rs/remove-inventory-routes branch July 25, 2022 16:29
coury-clark pushed a commit that referenced this pull request Jul 25, 2022
Instrumentation showed that these endpoints aren't being used and it
looks like there weren't even any handlers attached to the routes.

Confirmed that they were removed a long time ago:
https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph/-/commit/8572e643fa4a0a024a4be7d2441a45649800368f
efritz pushed a commit that referenced this pull request Jul 26, 2022
Instrumentation showed that these endpoints aren't being used and it
looks like there weren't even any handlers attached to the routes.

Confirmed that they were removed a long time ago:
https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph/-/commit/8572e643fa4a0a024a4be7d2441a45649800368f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants