This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: remove interval step reset when toggling all repos during creation#39261
Merged
Conversation
Contributor
Author
|
@unclejustin @vovakulikov a friendly reminder that this is ready for review. |
vovakulikov
approved these changes
Jul 26, 2022
vovakulikov
left a comment
Contributor
There was a problem hiding this comment.
Thanks @chwarwick (and thanks for reminder)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During insight creation removes the changes to the step between data points when the user switches from scoped to all repos.
resolves https://github.com/sourcegraph/sourcegraph/issues/39103
Test plan
In Search Insight creation:
all reposIn Detect and Track Insight creation:
all reposApp preview:
Check out the client app preview documentation to learn more.