This repository was archived by the owner on Sep 30, 2024. It is now read-only.
sg: Add description field to sg commands#39240
Merged
Merged
Conversation
bobheadxi
reviewed
Jul 21, 2022
bobheadxi
reviewed
Jul 21, 2022
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff d70a53b...5b960c9.
|
bobheadxi
reviewed
Jul 21, 2022
Co-authored-by: Robert Lin <robert@bobheadxi.dev>
Co-authored-by: Robert Lin <robert@bobheadxi.dev>
Co-authored-by: Robert Lin <robert@bobheadxi.dev>
jhchabran
approved these changes
Jul 25, 2022
jhchabran
left a comment
Contributor
There was a problem hiding this comment.
Nice idea, I think this will help discoverability!
| * repo-updater | ||
| * searcher | ||
| * server | ||
| * server: Run an all-in-one sourcegraph/server image |
Contributor
There was a problem hiding this comment.
This is a great idea! While it's kind of common knowledge that the server refers to the all in one instance, the description adds value in there.
| * otel-collector: OpenTelemetry collector | ||
| * postgres_exporter | ||
| * prometheus | ||
| * redis-postgres |
Contributor
There was a problem hiding this comment.
Dockerized version of redis and postgres
| * symbols | ||
| * syntax-highlighter | ||
| * web | ||
| * web-standalone-http |
Contributor
There was a problem hiding this comment.
This and the following one would benefit from having a description too!
Member
There was a problem hiding this comment.
Yeah all the web stuff could do with some descriptions, cc @sourcegraph/frontend-platform-devs - but I don't think it needs to be in this PR :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
descriptionfield tosgcommands specified insg.config.yamlThe description is displayed in the list of commands when running
sg runTest plan
sg runsg.config.yaml