This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Fix missing button in code nav policy config in small browser window#39115
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 780ecda...10dd9cd.
|
chrismwendt
commented
Jul 19, 2022
| <Link to={`./configuration/${policy.id}`} className="p-0"> | ||
| <Icon svgPath={mdiChevronRight} inline={false} aria-label="Configure" /> | ||
| </Link> | ||
| </span> |
Contributor
Author
There was a problem hiding this comment.
I completely removed the wrapper <span> because all it did was:
- Hide the button on
md(medium) and smaller windows, but that was bad because it's the only way to edit a policy - Move the chevron to the next row, but it's small enough to always show it on the side
efritz
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/sourcegraph/sourcegraph/issues/29097
Test plan
Ran locally.
App preview:
Check out the client app preview documentation to learn more.