This repository was archived by the owner on Sep 30, 2024. It is now read-only.
batches: temporarily disable namespace selector#37187
Merged
Merged
Conversation
Closed
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff b65db9c...4f1ad80.
|
Contributor
Author
|
Chromatic diff looks good. |
eseliger
approved these changes
Jun 14, 2022
| <Container className="mb-4"> | ||
| {error && <ErrorAlert error={error} />} | ||
| <NamespaceSelector | ||
| {/* TODO: As we haven't finished implementing support for orgs, we've temporary |
Member
There was a problem hiding this comment.
Can we just disable it? Otherwise the UI is so empty 😆
Contributor
Author
There was a problem hiding this comment.
If we disable it, I think we need the "coming soon" indicator too or something. 😅 I'll see how easy it is to slap that on instead.
Contributor
Author
There was a problem hiding this comment.
Done!
Fixed the mis-matched label text style while I was there. 😄
Piszmog
approved these changes
Jun 14, 2022
LawnGnome
approved these changes
Jun 14, 2022
LawnGnome
left a comment
Contributor
There was a problem hiding this comment.
+1 to Erik's comment, otherwise LGTM.
BolajiOlajide
approved these changes
Jun 14, 2022
unclejustin
pushed a commit
that referenced
this pull request
Jun 15, 2022
LawnGnome
added a commit
that referenced
this pull request
Sep 27, 2022
This reverts commit 4c1d0c5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/sourcegraph/sourcegraph/issues/37135.
Just comments out code related to the namespace selector and adds
TODOnotes with instructions for how to restore. Creating a batch change from the user or org list page will also both temporarily point to the default create page, since the user- and org-specific create pages pre-select a different namespace.Test plan
Manually tested that creating a batch change uses the user namespace only. Form has storybook coverage as well and should report a diff to Chromatic.
App preview:
Check out the client app preview documentation to learn more.