This repository was archived by the owner on Sep 30, 2024. It is now read-only.
monitoring: wrap alert_count records in min/max#11985
Merged
Merged
Conversation
1016a58 to
0fce11c
Compare
bobheadxi
added a commit
that referenced
this pull request
Jul 7, 2020
emidoots
reviewed
Jul 7, 2020
emidoots
reviewed
Jul 7, 2020
Co-authored-by: Stephen Gutekanst <stephen.gutekanst@gmail.com>
…ribution/provisioning-alerts-fix
Codecov Report
@@ Coverage Diff @@
## master #11985 +/- ##
==========================================
+ Coverage 49.57% 49.94% +0.36%
==========================================
Files 1505 1517 +12
Lines 88076 88478 +402
Branches 6789 6669 -120
==========================================
+ Hits 43665 44186 +521
+ Misses 40485 40363 -122
- Partials 3926 3929 +3
|
bobheadxi
added a commit
that referenced
this pull request
Jan 25, 2021
bobheadxi
added a commit
that referenced
this pull request
Jan 27, 2021
Re-introduce "flattening" of observables by wrapping queries in a min or max where appropriate (first added in #11985) to fix a regression introduced in #17599. Also add monitoring to ensure we have some visibility into rule failures, and reorganize Prometheus panels for uniformity. Co-authored-by: Gonzalo Peci <pecigonzalo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap all
alert_countrecords in a min/max operators, and removes "support" for per-instance since this eliminates per-container / per-replica / per-pod labels from the final alert_count rule calculation. This closes #11571, resolving a bug where per-instance support in provisioning alerts were causing them to not apply. See https://github.com/sourcegraph/sourcegraph/issues/11571#issuecomment-654571953Adjust wording and descriptions on the provisioning alerts.
I tried this out with new
gitserverrules via the steps I described here on k8s and provisioning alerts seem to be green now