This repository was archived by the owner on Sep 30, 2024. It is now read-only.
dev: silence grafana build output#11486
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11486 +/- ##
=======================================
Coverage 46.70% 46.71%
=======================================
Files 1397 1397
Lines 79069 79069
Branches 6814 6715 -99
=======================================
+ Hits 36932 36934 +2
+ Misses 38627 38626 -1
+ Partials 3510 3509 -1
|
mrnugget
approved these changes
Jun 15, 2020
LawnGnome
added a commit
that referenced
this pull request
Jun 16, 2020
The changes in #11483 made it difficult to start Grafana within a Linux development environment, and #11486 obscured the error in the goreman output. This restores the previous behaviour around the UID the container will run as, and ensures that logs will be dumped if the container exits unexpectedly.
LawnGnome
added a commit
that referenced
this pull request
Jun 16, 2020
* dev: fix Grafana startup on Linux The changes in #11483 made it difficult to start Grafana within a Linux development environment, and #11486 obscured the error in the goreman output. This restores the previous behaviour around the UID the container will run as, and ensures that logs will be dumped if the container exits unexpectedly. * Always overwrite grafana.log
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://sourcegraph.slack.com/archives/C07KZF47K/p1592213587300500?thread_ts=1592213304.293600&cid=C07KZF47K