renderer: add background colors to callouts#11
Merged
Conversation
bobheadxi
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
May 10, 2024
…ic formatting (#62607) Closes CORE-20: adds a small per-service "incident response" section near the alerts reference section of each service, providing some simple starter context and linking to other relevant guidance. This change also makes some Notion-oriented formatting tweaks: putting all paragraphs on a single line (because of sourcegraph/notionreposync#9) and also rendering callouts with appropriate background colors (sourcegraph/notionreposync#11). ## Test plan Golden tests, roll out to Notion: ```sh GITHUB_ACTIONS=true sg msp ops generate-handbook-pages ``` Incident response:  Callouts: 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes things a little more striking, and closer to how GitHub renders callouts.
Closes #10
Tested in https://github.com/sourcegraph/sourcegraph/pull/62607: