feat(appliance): pass serialized values into annotation#509
Closed
craigfurman wants to merge 1 commit into
Closed
Conversation
Contributor
|
Closing this as it's no longer required. |
Chickensoupwithrice
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Jul 25, 2024
…nd appliance cfg defaults (#64021) <!-- PR description tips: https://www.notion.so/sourcegraph/Write-a-good-pull-request-description-610a7fd3e613496eb76f450db5a49b6e --> This PR implements [this comment](https://linear.app/sourcegraph/issue/REL-218/ingressservice-consistency-for-helm-deployment#comment-6e1b88b5) from [REL-218](https://linear.app/sourcegraph/issue/REL-218/ingressservice-consistency-for-helm-deployment). ~~Currently, not included in `reconcileFrontendService` or `reconcileFronteendIngress`. It's still a **work in progress**, requesting review to make sure I'm on the right path, the test doesn't currently pass.~~ Got the tests to pass locally, and added them to `reconcileFronteendService` and `reconcileFronteendIngress`, however, I'd like to deploy this locally with helm to ease my concern in it breaking. ~~This PR alone isn't enough to close REL-218 either, we'll need something like @craigfurman's [PR in deploy-sourcegraph-helm](sourcegraph/deploy-sourcegraph-helm#509) as well~~ This PR no longer requires that helm values be serialized, since we adopt the object that exists in k8s rather than reading serialized helm values. ## Test plan <!-- REQUIRED; info at https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> Unit tests included ## Changelog <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c --> - feat/appliance: Include existing objects when constructing Frontend's `Service` & `Ingress` --------- Co-authored-by: Craig Furman <craig.furman@sourcegraph.com>
craigfurman
pushed a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Jul 31, 2024
…nd appliance cfg defaults (#64021) <!-- PR description tips: https://www.notion.so/sourcegraph/Write-a-good-pull-request-description-610a7fd3e613496eb76f450db5a49b6e --> This PR implements [this comment](https://linear.app/sourcegraph/issue/REL-218/ingressservice-consistency-for-helm-deployment#comment-6e1b88b5) from [REL-218](https://linear.app/sourcegraph/issue/REL-218/ingressservice-consistency-for-helm-deployment). ~~Currently, not included in `reconcileFrontendService` or `reconcileFronteendIngress`. It's still a **work in progress**, requesting review to make sure I'm on the right path, the test doesn't currently pass.~~ Got the tests to pass locally, and added them to `reconcileFronteendService` and `reconcileFronteendIngress`, however, I'd like to deploy this locally with helm to ease my concern in it breaking. ~~This PR alone isn't enough to close REL-218 either, we'll need something like @craigfurman's [PR in deploy-sourcegraph-helm](sourcegraph/deploy-sourcegraph-helm#509) as well~~ This PR no longer requires that helm values be serialized, since we adopt the object that exists in k8s rather than reading serialized helm values. ## Test plan <!-- REQUIRED; info at https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> Unit tests included ## Changelog <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c --> - feat/appliance: Include existing objects when constructing Frontend's `Service` & `Ingress` --------- Co-authored-by: Craig Furman <craig.furman@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to https://linear.app/sourcegraph/issue/REL-218/ingressservice-consistency-for-helm-deployment but does not close it
Checklist
Test plan
Ran
helm template charts/sourcegraph-appliance