pure-docker: deploy otel-collector by default#849
Merged
Conversation
b95ad97 to
4cd4453
Compare
2b2dd72 to
7a6f322
Compare
sanderginn
approved these changes
Aug 26, 2022
Comment on lines
+7
to
+8
| if [ -e ~/sourcegraph-docker/zoekt-shared-disk ]; then | ||
| mv ~/sourcegraph-docker/zoekt-shared-disk ~/sourcegraph-docker/zoekt-$1-shared-disk |
2 tasks
6 tasks
4ec016f to
806c7e9
Compare
2 tasks
bobheadxi
added a commit
that referenced
this pull request
Sep 6, 2022
#849 took a conservative approach to sourcegraph/sourcegraph#40455 by keeping Jaeger around. I've since reached out to the only customer using this deployment mechanism (https://sourcegraph.slack.com/archives/C012V43N8E7/p1662138872279299) which indicates there is no strong interest in keeping Jaeger around, so this change removes it entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds OpenTelemetry collector by default and send traces through
otel-collector, similar to #848 , except forpure-dockerwe opt to keep Jaeger as part of the default deployment for simplicity.I've also updated the tags used here to release tags using
tools/update-docker-tags.shfor testing - this old tool does not support "latest"-style versions, andsg ops update-imagesdoes not support pure-docker, so this gets us "close enough" in order to test the OpenTelemetry setup.Closes https://github.com/sourcegraph/sourcegraph/issues/40455
Checklist
Test plan
pure-docker/deploy.sh