Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

Add kustomize to new base cluster with minimal permissions #4214

Merged
abeatrix merged 1 commit into
bl/new-basefrom
bee/kustomize-new-base
Dec 14, 2022
Merged

Add kustomize to new base cluster with minimal permissions #4214
abeatrix merged 1 commit into
bl/new-basefrom
bee/kustomize-new-base

Conversation

@abeatrix

Copy link
Copy Markdown
Contributor

RE: https://sourcegraph.slack.com/archives/C02E4HE42BX/p1670969373552729?thread_ts=1670956128.048659&cid=C02E4HE42BX

This PR adds kustomize to the new base cluster with minimal permissions.

A new kustomize directory with overlay and components samples is also added to the new/kustomize directory.

Checklist

Test plan

There are two ways to try the changes made in this PR:

  1. Local build
  2. Remote build

Local build

  1. Clone this repository and check out this branch
  2. Follow the instruction in the new/kustomize/README.md

Remote build

  1. Run the commands below on your local machine.
  2. The new set of manifests with the new changes made with the sample overlay will then be output to the$HOME/newKustomizeBase directory.
mkdir $HOME/newKustomizeBase
kustomize build https://github.com/sourcegraph/deploy-sourcegraph/new/kustomize/overlays?ref=bee/kustomize-new-base -o $HOME/newKustomizeBase/

@abeatrix abeatrix requested review from a team and beyang December 14, 2022 00:21
kind: Kustomization
namespace: new-sourcegraph
resources:
- https://github.com/sourcegraph/deploy-sourcegraph/new/resources/sourcegraph?ref=bee/kustomize-new-base

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these reference file paths rather than URLs, for version consistency?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beyang Good question, sorry for not clarifying in the PR. I'm currently using the URL with ref=bee/kustomize-new-base as an example to demonstrate remote build, since the kustomiziation.yaml in the base layer of any of the ref=version_number does not exist yet.

Once the kustomiziation.yaml files for the base folder (example here) are merged to main and added to the next release, we can then point it to the new version using the ref tag for each release when using remote build.

File paths should be used for local builds though, I will add these to the docs, or do you think we should just use file paths by default?

@abeatrix abeatrix merged commit 23054ba into bl/new-base Dec 14, 2022
@abeatrix abeatrix deleted the bee/kustomize-new-base branch December 14, 2022 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants