feat: add experimental chat panel by abeatrix · Pull Request #1486 · sourcegraph/cody-public-snapshot

abeatrix · 2023-10-24T23:07:22Z

Close https://github.com/sourcegraph/cody/issues/1522

New Chat UI

This PR adds a new experimental chat panel UI behind cody.experimental.chatPanel config that create separate views for commands, search, chats, and settings.
It also adds chat panel-related configuration options and commands.
Also updated the chat behavior to always start with empty chat, other than that, the chat behavior remains the same as the current one
Support multiple chat session

How does it work

The ChatViewManager class manages different chat view provider instances and handles switching between them based on config, and uses currentProvider or sidebarViewProvider to run chat commands.

A chat view provider (ChatViewProvider or ChatPanelProvider) is a class that implements the VS Code WebviewViewProvider interface to display a webview or webview panel for chat.

The ChatViewManager maintains:

sidebarViewProvider - An instance of ChatViewProvider for the sidebar auth flow and default chat view. This is always kept around.
chatPanelProviders - A map of ChatPanelProvider instances for editor panels, enabled when experimentalChatPanel config is true.
currentProvider - The currently active provider instance.

It decides which provider to use based on the experimentalChatPanel config:

When false, it uses the sidebarViewProvider.
When true, it creates a ChatPanelProvider if none exists yet, and uses that.

To execute commands, it first checks currentProvider, and if not set, defaults to using sidebarViewProvider.

After executing the command, it sets currentProvider to the provider used.

Test plan

You can switch between the new chat UI and the current one from Cody Setting under New Chat UI:

See video below for a quick walkthrough:

Demo_.New.Chat.UI.v0.mp4

WIP

To do items from @toolmantim

Bugs

Looks like it’s enabled by default for me (have been testing w/ separate instance)
Chats opening multiple tabs
Chats not opening - pending for repro steps
Changing active chat should change selected item in treeview
Delete all chats sometimes just deletes the last one, sometimes deletes all
Sign out with chat window open doesn't close existing chats
Sometimes it gets in a state where clicking the buttons in the chats treeview fail with command not found errors
Creating new chats in succession causes some to fail to load
This may be existing behaviour, but a blank unsaved editor seems to work but if you add some lines of code then it fails saying no file is open

Changes

TBD

“Custom Commands” item too strong for experimental feature I think, and we move to just an action button on panel root. If they have custom commands defined, we can have a collapsed “Custom Commands” item with a badge count that expands to show all the commands?
Clicking command with no editor open does nothing. Can we disable treeview items that need a file? Notification would feel too abrupt. Something else?

I'm going to move the following items to a seperate PRs since they affect the current behavior:

“Sign Out” needs a confirmation https://github.com/sourcegraph/cody/issues/1520
too many experimental features in the settings menu https://github.com/sourcegraph/cody/issues/1521

valerybugakov

Exciting! Thank you for the video overview. 🙌
I reviewed the PR, focusing on the implementation details, leaving UI/UX to @toolmantim.

valerybugakov · 2023-10-25T04:03:35Z

+        this.treeView = treeView
+    }
+
+    private async onDidReceiveMessage(message: WebviewMessage): Promise<void> {


Does it make sense to share part of the existing logic from ChatViewProvider with the new ChatPanelProvider to ensure we fix bugs for both implementations while ChatPanelProvider is behind the feature flag? Do we need to handle all the same messages as ChatViewProvider here?

toolmantim

Woohoo! Just gave it a test, and left you some testing notes in Slack.

abeatrix · 2023-10-25T17:33:45Z

To do items from @toolmantim

Edit: moved to PR description under WIP

Co-authored-by: Valery Bugakov <skymk1@gmail.com>

toolmantim

It's starting to feel much more solid now! The pre-existing bugs which you asked for repo-steps for seem to be fixed 🙌🏼

Left a few small suggestions and found a few more bugs in testing:

Sign out with chat window open doesn't close existing chats, which has some odd side-effects:

Screen.Recording.2023-10-26.at.4.52.41.pm.mov

Screen.Recording.2023-10-26.at.4.52.41.pm.1.mov

Sometimes it gets in a state where clicking the buttons in the chats treeview fail with command not found errors:

Screen.Recording.2023-10-26.at.7.38.06.pm.mov

Creating new chats in succession causes some to fail to load:

Screen.Recording.2023-10-26.at.7.36.14.pm.mov

This may be existing behaviour, but a blank unsaved editor seems to work but if you add some lines of code then it fails saying no file is open:

Screen.Recording.2023-10-26.at.4.54.00.pm.mov

Co-authored-by: Tim Lucas <t@toolmantim.com>

…into bee/new-chat-ui

Co-authored-by: Valery Bugakov <skymk1@gmail.com>

abeatrix · 2023-10-26T23:51:32Z

@toolmantim Thank you so much for reporting all the bugs you found! I think I fixed all the bugs you last reported 🤞 Can you give the latest commit a try and let me know if you find other bugs before I move onto implementing the items on the rest of the list (see PR description under WIP section)? 🙇‍♀️

toolmantim

Looks great! I just pushed some tweaks after playing with it for real.

…ch don't support inlay models. (#1490) ImaginaryEditor does not support InlayModel and throws an UnsupportedOperationException; IntentionPreviewEditor throws an IntentionPreviewUnsupportedOperationException: UnsupportedOperationException, etc. Fixes #1488, #1486, #1485, #1480, #1466, #1462, #1435, #1363 ## Test plan ``` ./gradlew test --tests InlayModelUtilTest ``` Ran the IDE and clicked between editors, requesting autocompletes.

abeatrix added 2 commits October 24, 2023 15:58

feat: add experimental chat panel

5705c44

Merge branch 'main' into bee/new-chat-ui

b63f3f4

abeatrix requested review from a team, beyang and toolmantim October 24, 2023 23:07

fix auth flow

5e597c2

valerybugakov reviewed Oct 25, 2023

View reviewed changes

toolmantim reviewed Oct 25, 2023

View reviewed changes

Comment thread vscode/src/services/TreeViewProvider.ts Outdated

Comment thread vscode/webviews/Chat.tsx Outdated

abeatrix and others added 8 commits October 25, 2023 11:55

fixes

065c1e3

updates

9fa74af

fix editor

ca7120a

fix executeCustomCommand

8867b89

update setWebviewView and customCommands

403c6c1

fix tests

7aafa72

update icons

aa3d56d

Update active-editor.ts

b2aa91e

Co-authored-by: Valery Bugakov <skymk1@gmail.com>

toolmantim reviewed Oct 26, 2023

View reviewed changes

Comment thread vscode/src/services/TreeViewProvider.ts Outdated

Comment thread vscode/package.json Outdated

abeatrix and others added 10 commits October 26, 2023 05:45

Apply suggestions from code review

858effe

Co-authored-by: Tim Lucas <t@toolmantim.com>

Merge branch 'bee/new-chat-ui' of https://github.com/sourcegraph/cody …

644284f

…into bee/new-chat-ui

Apply suggestions from code review

188b626

Co-authored-by: Valery Bugakov <skymk1@gmail.com>

add syncAuthStatus

da9a623

Merge branch 'main' into bee/new-chat-ui

72ad3af

fix opening multiple windows

7764c4d

Merge branch 'main' into bee/new-chat-ui

aefae87

clean up

0fc9d0c

support untitled and notebook files for tracking active editor

5059dec

add version number to help sidebar

e20321c

abeatrix mentioned this pull request Oct 27, 2023

[Tracking Issue]: Refactor Chat to No-magic Chat #1410

Closed

Icon, confirmation and nav cleanups

81ddd38

toolmantim approved these changes Oct 27, 2023

View reviewed changes

abeatrix added 7 commits October 27, 2023 15:35

clean up

4bb3b8a

Merge branch 'main' into bee/new-chat-ui

8d92009

clean up

6c7acbc

fix first message

64014f8

Merge branch 'main' into bee/new-chat-ui

9b0bd17

add error handling

3653b05

update MessageErrorType in panel

031eb42

abeatrix merged commit 0b78461 into main Oct 30, 2023

abeatrix deleted the bee/new-chat-ui branch October 30, 2023 18:50

kalanchan mentioned this pull request Nov 7, 2023

PRD: [VSC] Users can easily manage conversations with Cody #1650

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add experimental chat panel#1486

feat: add experimental chat panel#1486
abeatrix merged 29 commits into
mainfrom
bee/new-chat-ui

abeatrix commented Oct 24, 2023 •

edited

Loading

Uh oh!

valerybugakov left a comment

Uh oh!

valerybugakov Oct 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

toolmantim left a comment

Uh oh!

Uh oh!

Uh oh!

abeatrix commented Oct 25, 2023 •

edited

Loading

Uh oh!

toolmantim left a comment

Uh oh!

Uh oh!

Uh oh!

abeatrix commented Oct 26, 2023

Uh oh!

toolmantim left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

abeatrix commented Oct 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Chat UI

How does it work

The ChatViewManager maintains:

Next

Test plan

WIP

To do items from @toolmantim

Bugs

Changes

TBD

Uh oh!

valerybugakov left a comment

Choose a reason for hiding this comment

Uh oh!

valerybugakov Oct 25, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

toolmantim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

abeatrix commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To do items from @toolmantim

Uh oh!

toolmantim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

abeatrix commented Oct 26, 2023

Uh oh!

toolmantim left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

abeatrix commented Oct 24, 2023 •

edited

Loading

abeatrix commented Oct 25, 2023 •

edited

Loading