[sonic-installer] Hyphens instead of underscores in command and subcommands#983
Merged
jleveque merged 14 commits intosonic-net:masterfrom Jul 14, 2020
jleveque:sonic_utilities_hyphens
Merged
[sonic-installer] Hyphens instead of underscores in command and subcommands#983jleveque merged 14 commits intosonic-net:masterfrom jleveque:sonic_utilities_hyphens
jleveque merged 14 commits intosonic-net:masterfrom
jleveque:sonic_utilities_hyphens
Conversation
qiluo-msft
reviewed
Jul 11, 2020
added 6 commits
July 11, 2020 20:39
…own 'amon' docker
qiluo-msft
reviewed
Jul 13, 2020
qiluo-msft
reviewed
Jul 13, 2020
qiluo-msft
approved these changes
Jul 13, 2020
Contributor
Author
|
Retest this please |
jleveque
added a commit
that referenced
this pull request
Sep 1, 2020
Ensure aliases.ini gets installed with the sonic_installer package to enable backward-compatibility with the versions of subcommands which contain underscores. This was missed in #983
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
…d (#995) Root group name was changed from `cli` to `sonic_installer` in sonic-net/sonic-utilities#983. However, `verify-next-image` subcommand was being added in an already-open PR sonic-net/sonic-utilities#979 at the time. It did not get updated before merge. This aligns it with the new group name.
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
Ensure aliases.ini gets installed with the sonic_installer package to enable backward-compatibility with the versions of subcommands which contain underscores. This was missed in sonic-net/sonic-utilities#983
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace underscores with hyphens in all sonic-installer subcommands as well as the root command itself.
Install two entry points for sonic-installer:
sonic-installerandsonic_installer. This allows for backward compatibility and time for users to transition from using the underscore versions to the hyphenated versions.Replace underscores with hyphens in the following subcommands:
Print deprecation warnings to stderr if issued command line contains any deprecated versions with underscores
Bonus: Addition of the AliasedGroup base class also adds support for abbreviated subcommands
Fixed some style issues which did not align with PEP8 standards
Eliminate duplicate code by adding DOCKER_CONTAINER_LIST; Remove unknown 'amon' container from the list
This is work towards resolving issue #982. We can set a deprecation date for the underscore versions of the commands, and when that date arrives, we can simply delete all aliases and deprecation warnings.