Changes to commands config reload/load-minigraph#919
Merged
abdosi merged 3 commits intosonic-net:masterfrom May 20, 2020
Merged
Changes to commands config reload/load-minigraph#919abdosi merged 3 commits intosonic-net:masterfrom
abdosi merged 3 commits intosonic-net:masterfrom
Conversation
load_minigraph command. This will be needed when executed from config-setup script.
4e00f2b to
b346302
Compare
jleveque
suggested changes
May 20, 2020
Contributor
jleveque
left a comment
There was a problem hiding this comment.
When adding/removing commands or modifying their names/options/arguments, please also modify docs/CommandReference.md to reflect the changes.
Contributor
Author
@jleveque Thanks for pointing out. Done |
jleveque
suggested changes
May 20, 2020
doc/Command-Reference.md
Outdated
| When user specifies the optional argument "-y" or "--yes", this command forces the loading without prompting the user for confirmation. | ||
| If the argument is not specified, it prompts the user to confirm whether user really wants to load this configuration file. | ||
|
|
||
| When user specifies the optional argument "-n" or "--no-service-restart", this command loads the configuration without restarting various services |
Contributor
There was a problem hiding this comment.
s/various services/dependent services/
doc/Command-Reference.md
Outdated
| When user specifies the optional argument "-y" or "--yes", this command forces the loading without prompting the user for confirmation. | ||
| If the argument is not specified, it prompts the user to confirm whether user really wants to load this configuration file. | ||
|
|
||
| When user specifies the optional argument "-n" or "--no-service-restart", this command clear and loads the configuration without restarting various services |
Contributor
There was a problem hiding this comment.
s/various services/dependent services/
doc/Command-Reference.md
Outdated
| If the argument is not specified, it prompts the user to confirm whether user really wants to load this configuration file. | ||
|
|
||
| When user specifies the optional argument "-n" or "--no-service-restart", this command clear and loads the configuration without restarting various services | ||
| running on the device. One of the use case for this option is during boot time when config-setup service loads exisitng old configuration and there is no services |
Contributor
There was a problem hiding this comment.
s/One of the use case/One use case/
s/exisitng/existing/
s/there is no services/there are no services/
doc/Command-Reference.md
Outdated
| If the argument is not specified, it prompts the user to confirm whether user really wants to load this configuration file. | ||
|
|
||
| When user specifies the optional argument "-n" or "--no-service-restart", this command loads the configuration without restarting various services | ||
| running on the device. One of the use case for this option is during boot time when config-setup service loads minigraph configuration and there is no services |
Contributor
There was a problem hiding this comment.
s/One of the use case/One use case/
s/there is no services/there are no services/
jleveque
approved these changes
May 20, 2020
abdosi
added a commit
that referenced
this pull request
May 20, 2020
* Changes to ignore services stop/start for config reload and load_minigraph command. This will be needed when executed from config-setup script. * Updated Command Reference document * Address Review Comments.
abdosi
added a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
* Changes to ignore services stop/start for config reload and load_minigraph command. This will be needed when executed from config-setup script. * Updated Command Reference document * Address Review Comments.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[201911][show] Fix abbreviations for 'show ip bgp ...' commands (sonic-net#909) Changes to support acl-loader and mirror-session config commands for multi-npu platforms. (sonic-net#908) Changes to commands config reload/load-minigraph (sonic-net#919) Stop/Start restapi server upon config reload (sonic-net#911) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Changes to make commands config reload/load-minigraph
to have option of not stop/start docker services. This is not needed
when this commands are called from config-setup shell script. PR: sonic-net/sonic-buildimage#4609 used this change.
- How I did it
Added new option -n (--no-service-restart) with default as False
so that existing command behavior remains same.
- How to verify it
Verified Manually and as well when invoke with config-setup