Skip to content

Fixes bug for PFCWD feature parameters#838

Merged
lguohan merged 6 commits intosonic-net:masterfrom
shlomibitton:shlomi_bug_1971215
Apr 7, 2020
Merged

Fixes bug for PFCWD feature parameters#838
lguohan merged 6 commits intosonic-net:masterfrom
shlomibitton:shlomi_bug_1971215

Conversation

@shlomibitton
Copy link
Copy Markdown
Contributor

@shlomibitton shlomibitton commented Mar 17, 2020

  • What I did
    The feature allows setting 'detection_time', 'restoration_time' and 'pollling_interval' PFCWD to an interface. The 'pollling_interval' must be lower than 'detection_time' and 'restoration_time'.
    The fix is checking if there is a lower value of 'detection_time' or 'restoration_time' than the 'pollling_interval' value entered by the user in config DB, if yes exit with error code 1.

  • How I did it
    Checking the config DB for interfaces PFCWD values.

  • How to verify it
    Try adding 'pollling_interval' greater than one of the values of PFCWD interfaces.

  • Previous command output (if the output of a command-line utility has changed)
    No Output.

  • New command output (if the output of a command-line utility has changed)
    unable to use polling_interval = #ms, value is bigger or equal to the minimum in PFCWD table

@shlomibitton
Copy link
Copy Markdown
Contributor Author

@volodymyrsamotiy @liat-grozovik
please review

liat-grozovik
liat-grozovik previously approved these changes Mar 17, 2020
Copy link
Copy Markdown
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

neethajohn
neethajohn previously approved these changes Mar 30, 2020
@lguohan lguohan merged commit 2cc70f3 into sonic-net:master Apr 7, 2020
@shlomibitton shlomibitton deleted the shlomi_bug_1971215 branch April 30, 2020 13:12
abdosi pushed a commit that referenced this pull request Jun 16, 2020
What I did

The feature allows setting 'detection_time', 'restoration_time' and 'pollling_interval' PFCWD to an interface. The 'pollling_interval' must be lower than 'detection_time' and 'restoration_time'.
The fix is checking if there is a lower value of 'detection_time' or 'restoration_time' than the 'pollling_interval' value entered by the user in config DB, if yes exit with error code 1.

How I did it
Checking the config DB for interfaces PFCWD values.

How to verify it
Try adding 'pollling_interval' greater than one of the values of PFCWD interfaces.

Previous command output (if the output of a command-line utility has changed)
No Output.

New command output (if the output of a command-line utility has changed)
unable to use polling_interval = #ms, value is bigger or equal to the minimum in PFCWD table
abdosi added a commit to abdosi/sonic-mgmt that referenced this pull request Jun 22, 2020
there is check pfc_wd poll_time <= pfc_wd_detection/restoration_time.
So make sure in testscript before setting poll interval stop
pfc wd if enable by default because default detection/restoration time
can be < poll time interval making script failure.
abdosi added a commit to sonic-net/sonic-mgmt that referenced this pull request Jun 23, 2020
there is check pfc_wd poll_time <= pfc_wd_detection/restoration_time.
So make sure in testscript before setting poll interval stop
pfc wd if enable by default because default detection/restoration time
can be < poll time interval making script failure.
yxieca pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Jun 24, 2020
there is check pfc_wd poll_time <= pfc_wd_detection/restoration_time.
So make sure in testscript before setting poll interval stop
pfc wd if enable by default because default detection/restoration time
can be < poll time interval making script failure.
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
What I did

The feature allows setting 'detection_time', 'restoration_time' and 'pollling_interval' PFCWD to an interface. The 'pollling_interval' must be lower than 'detection_time' and 'restoration_time'.
The fix is checking if there is a lower value of 'detection_time' or 'restoration_time' than the 'pollling_interval' value entered by the user in config DB, if yes exit with error code 1.

How I did it
Checking the config DB for interfaces PFCWD values.

How to verify it
Try adding 'pollling_interval' greater than one of the values of PFCWD interfaces.

Previous command output (if the output of a command-line utility has changed)
No Output.

New command output (if the output of a command-line utility has changed)
unable to use polling_interval = #ms, value is bigger or equal to the minimum in PFCWD table
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
 [201911][thermal control] Backport changes from master branch (sonic-net#929)
     [201911][config] Support abbreviation (sonic-net#933)
       Add 'hw-management-generate-dump.sh' to 'show techsupport'
       command (sonic-net#934)
       [fwutil]: Update fwutil to v2.0.0.0. (sonic-net#942)
       Fixes bug for PFCWD feature parameters (sonic-net#838)
     Fixed fast-reboot for BFN platform (sonic-net#871)
     [config] Add 'interface transceiver' subgroup with 'lpmode' and
     'reset' subcommands (sonic-net#904)
      [warm-reboot]: added pre-check for ISSU file (sonic-net#915)
       [config] Don't attempt to restart disabled services (sonic-net#944)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants