[neighbor advertiser] remove http endpoint access#792
Merged
yxieca merged 2 commits intosonic-net:masterfrom Jan 27, 2020
Merged
[neighbor advertiser] remove http endpoint access#792yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
daall
reviewed
Jan 27, 2020
daall
approved these changes
Jan 27, 2020
yxieca
added a commit
that referenced
this pull request
Jan 27, 2020
* [neighbor advertiser] remove http endpoint access Signed-off-by: Ying Xie <ying.xie@microsoft.com> * Remove obsolete comment
abdosi
pushed a commit
that referenced
this pull request
Feb 4, 2020
* [neighbor advertiser] remove http endpoint access Signed-off-by: Ying Xie <ying.xie@microsoft.com> * Remove obsolete comment
|
@yxieca are you going to fix wr_arp test case? Wr_Arp test use ferret.py file which can work only with HTTP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
remove http endpoint access