[aclshow] restore PRIO column and sort entries by priority#476
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Mar 11, 2019
Merged
[aclshow] restore PRIO column and sort entries by priority#476liat-grozovik merged 1 commit intosonic-net:masterfrom
liat-grozovik merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Roman Kachur <romankac@mellanox.com>
Merged
Contributor
|
If we're doing a primary sort by table name then a secondary sort by priority, does it make more sense to move the table name column to the far left, followed by the priority column, then rule name, etc? |
jleveque
reviewed
Mar 1, 2019
|
|
||
| ### acl display header | ||
| ACL_HEADER = ["RULE NAME", "TABLE NAME", "PACKETS COUNT", "BYTES COUNT"] | ||
| ACL_HEADER = ["RULE NAME", "TABLE NAME", "PRIO", "PACKETS COUNT", "BYTES COUNT"] |
Contributor
There was a problem hiding this comment.
Maybe use the full word, PRIORITY? It's only 4 more chars.
Contributor
Author
There was a problem hiding this comment.
Priority label was "PRIO" long before my changes
#442
This time I just reverted this label, as it was before.
lguohan
approved these changes
Mar 7, 2019
liat-grozovik
approved these changes
Mar 7, 2019
yxieca
pushed a commit
that referenced
this pull request
Mar 19, 2019
Signed-off-by: Roman Kachur <romankac@mellanox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roman Kachur romankac@mellanox.com
- What I did
I reverted PRIO column to aclshow output.
Set sorting of rules to 'first by Table then by Priority',
before it was 'first by Table then by Counter'.
- How I did it
Added PRIO column to aclshow, changes sorting.
- How to verify it
Load acl rules and run aclshow -a
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
-->