Skip to content

[spm] Rename entry tag variable to docker_image_reference#4019

Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom
DavidZagury:master_spm_rename_fix
Sep 3, 2025
Merged

[spm] Rename entry tag variable to docker_image_reference#4019
qiluo-msft merged 2 commits intosonic-net:masterfrom
DavidZagury:master_spm_rename_fix

Conversation

@DavidZagury
Copy link
Copy Markdown
Contributor

@DavidZagury DavidZagury commented Aug 6, 2025

What I did

Rename entry tag variable to docker_image_reference

How I did it

How to verify it

  • Run all package manager tests: pytest tests/sonic_package_manager
  • Install App Extension

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@DavidZagury DavidZagury force-pushed the master_spm_rename_fix branch from 3984e4a to 4b1c8ec Compare August 11, 2025 12:40
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@DavidZagury DavidZagury changed the title [spm] Remove docker_image_references dependency from tests [spm] Rename entry tag variable to docker_image_reference Aug 11, 2025
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@DavidZagury DavidZagury force-pushed the master_spm_rename_fix branch from d6038fd to 528b57c Compare August 11, 2025 14:41
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@DavidZagury DavidZagury force-pushed the master_spm_rename_fix branch from 528b57c to c5e1ebc Compare August 11, 2025 15:17
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@DavidZagury DavidZagury force-pushed the master_spm_rename_fix branch from c5e1ebc to 8d9e755 Compare August 11, 2025 17:27
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft
Copy link
Copy Markdown
Contributor

Could you test buildimage build with this new commit in sonic-utilities? Does it solve the previous submodule moving issue?

@DavidZagury
Copy link
Copy Markdown
Contributor Author

Could you test buildimage build with this new commit in sonic-utilities? Does it solve the previous submodule moving issue?

@qiluo-msft On our internal builds we are now running with this fix integrated and don't see these issues

@qiluo-msft qiluo-msft merged commit 7baa75b into sonic-net:master Sep 3, 2025
7 checks passed
@yejianquan
Copy link
Copy Markdown
Contributor

Hi @DavidZagury , 202505 branch is nearing piloting.
Is this commit mandatory for 202505 branch, can you please provide the business reason for this commit to be cherry-picked into 202505 branch?

@DavidZagury
Copy link
Copy Markdown
Contributor Author

@yejianquan this is the last PR to fix - sonic-net/sonic-buildimage#22124

@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202505: #4050

YairRaviv pushed a commit to YairRaviv/sonic-utilities that referenced this pull request Jan 12, 2026
…4019)

What I did
Rename entry tag variable to docker_image_reference

How I did it
How to verify it
Run all package manager tests: pytest tests/sonic_package_manager
Install App Extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants