[action] [PR:3972] [db_migrator] Fix parse_xml fails when minigraph has SonicQosProfile#4009
Merged
mssonicbld merged 1 commit intosonic-net:202505from Aug 1, 2025
Merged
Conversation
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git commit -s` **
If this is a bug fix, make sure your description includes "closes #xxxx",
"fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
issue when the PR is merged.
If you are adding/modifying/removing any command or utility script, please also
make sure to add/modify/remove any unit tests from the tests
directory as appropriate.
If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
subcommand, or you are adding a new subcommand, please make sure you also
update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
your changes.
Please provide the following information:
-->
#### What I did
This change is to fix sonic-net/sonic-buildimage#22120 "Bug: [db_migrator] parse_xml fails when minigraph has SonicQosProfile".
If there is `SonicQosProfile` in minigraph.xml, parse_xml fails with below error:
```
2025 Jul 14 06:49:23.590302 vlab-01 ERR db_migrator: Caught exception while trying to parse minigraph: join() argument must be str, bytes, or os.PathLike object, not 'NoneType'
```
It's because select_mmu_profiles needs platform.
https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-config-engine/minigraph.py#L1925
#### How I did it
This change added code in db_migrator.py to get platform info. While calling `parse_xml`, pass in the `platform` argument.
#### How to verify it
Add SonicQosProfile to minigraph:
```
<a:DeviceProperty>
<a:Name>SonicQosProfile</a:Name>
<a:Reference i:nil="true"/>
<a:Value>Balanced</a:Value>
</a:DeviceProperty>
```
Run `db_migrator.py -o migrate`. Check syslog, migration passed without exception.
#### Previous command output (if the output of a command-line utility has changed)
#### New command output (if the output of a command-line utility has changed)
Collaborator
Author
|
Original PR: #3972 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
kktheballer
pushed a commit
to kktheballer/sonic-utilities
that referenced
this pull request
Jan 14, 2026
```<br>* 1c262ab - (HEAD -> 202506) Merge branch '202505' of https://github.com/sonic-net/sonic-utilities into 202506 (2025-08-02) [Sonic Automation] * 5eac9e3 - (origin/202505) [db_migrator] Fix parse_xml fails when minigraph has SonicQosProfile (sonic-net#4009) (2025-08-01) [mssonicbld] * a3989b4 - Exclude Smart Switch from modular chassis operations/checks (sonic-net#4008) (2025-08-01) [mssonicbld]<br>```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
This change is to fix sonic-net/sonic-buildimage#22120 "Bug: [db_migrator] parse_xml fails when minigraph has SonicQosProfile".
If there is
SonicQosProfilein minigraph.xml, parse_xml fails with below error:It's because select_mmu_profiles needs platform.
https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-config-engine/minigraph.py#L1925
How I did it
This change added code in db_migrator.py to get platform info. While calling
parse_xml, pass in theplatformargument.How to verify it
Add SonicQosProfile to minigraph:
Run
db_migrator.py -o migrate. Check syslog, migration passed without exception.Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)