Skip to content

Fix database initialization for db_migrator#3100

Merged
ganglyu merged 7 commits intosonic-net:masterfrom
ganglyu:fix_db_migrator
Dec 25, 2023
Merged

Fix database initialization for db_migrator#3100
ganglyu merged 7 commits intosonic-net:masterfrom
ganglyu:fix_db_migrator

Conversation

@ganglyu
Copy link
Copy Markdown
Contributor

@ganglyu ganglyu commented Dec 25, 2023

What I did

db_migrator failed to initialize SonicDBConfig, and I fix this issue.

How I did it

If SonicDBConfig is already initialized, do not invoke initialize() again.

How to verify it

Run unit test, and verified on DUT.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@ganglyu ganglyu requested a review from wen587 December 25, 2023 04:50
@ganglyu ganglyu marked this pull request as ready for review December 25, 2023 04:53
@FengPan-Frank FengPan-Frank self-requested a review December 25, 2023 08:03
Copy link
Copy Markdown
Contributor

@FengPan-Frank FengPan-Frank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganglyu ganglyu merged commit 9400691 into sonic-net:master Dec 25, 2023
@ganglyu ganglyu deleted the fix_db_migrator branch January 30, 2024 06:31
mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Jan 30, 2024
What I did
db_migrator failed to initialize SonicDBConfig, and I fix this issue.

How I did it
If SonicDBConfig is already initialized, do not invoke initialize() again.

How to verify it
Run unit test, and verified on DUT.
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202311: #3137

mssonicbld pushed a commit that referenced this pull request Jan 30, 2024
What I did
db_migrator failed to initialize SonicDBConfig, and I fix this issue.

How I did it
If SonicDBConfig is already initialized, do not invoke initialize() again.

How to verify it
Run unit test, and verified on DUT.
liuh-80 added a commit that referenced this pull request Apr 25, 2024
…on on Linecard (#3257)

Fix db_migrate.py show error and back trace while loading configuration on Linecard

#### Why I did it
    Fix [issue @](sonic-net/sonic-buildimage#18389)

#### How I did it
    Revert code change by #3100
    Check DB config initialize state and ignore when initialized.

#### How to verify it
    Pass all UT.
    Manually test.

##### Work item tracking
- Microsoft ADO **(number only)**: 27384235

#### Which release branch to backport (provide reason below if selected)
    N/A

#### Description for the changelog
    Fix db_migrate.py show error and back trace while loading configuration on Linecard

#### A picture of a cute animal (not mandatory but encouraged)
arfeigin pushed a commit to arfeigin/sonic-utilities that referenced this pull request Jun 16, 2024
…on on Linecard (sonic-net#3257)

Fix db_migrate.py show error and back trace while loading configuration on Linecard

#### Why I did it
    Fix [issue @](sonic-net/sonic-buildimage#18389)

#### How I did it
    Revert code change by sonic-net#3100
    Check DB config initialize state and ignore when initialized.

#### How to verify it
    Pass all UT.
    Manually test.

##### Work item tracking
- Microsoft ADO **(number only)**: 27384235

#### Which release branch to backport (provide reason below if selected)
    N/A

#### Description for the changelog
    Fix db_migrate.py show error and back trace while loading configuration on Linecard

#### A picture of a cute animal (not mandatory but encouraged)
nmoray pushed a commit to nmoray/sonic-utilities that referenced this pull request Jun 25, 2025
What I did
db_migrator failed to initialize SonicDBConfig, and I fix this issue.

How I did it
If SonicDBConfig is already initialized, do not invoke initialize() again.

How to verify it
Run unit test, and verified on DUT.
nmoray pushed a commit to nmoray/sonic-utilities that referenced this pull request Jun 25, 2025
…on on Linecard (sonic-net#3257)

Fix db_migrate.py show error and back trace while loading configuration on Linecard

#### Why I did it
    Fix [issue @](sonic-net/sonic-buildimage#18389)

#### How I did it
    Revert code change by sonic-net#3100
    Check DB config initialize state and ignore when initialized.

#### How to verify it
    Pass all UT.
    Manually test.

##### Work item tracking
- Microsoft ADO **(number only)**: 27384235

#### Which release branch to backport (provide reason below if selected)
    N/A

#### Description for the changelog
    Fix db_migrate.py show error and back trace while loading configuration on Linecard

#### A picture of a cute animal (not mandatory but encouraged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants