[chassis]: Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC by arlakshm · Pull Request #3099 · sonic-net/sonic-utilities

arlakshm · 2023-12-22T06:03:07Z

What I did

Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC

Fixes: #3098
MSFT ADO: 26238398:

How I did it

On Chassis linecard with no external neighbors the show ip bgp summary fails because the on chassis linecard there are internal iBGP sessions are present so frr output has this information.

With this fix with this case is handled so that the commands do not display any error but instead we are display the below output

autotest@sonic:~$ show ip bgp summary

IPv4 Unicast Summary:
asic0: BGP router identifier 192.0.0.1, local AS number 65100 vrf-id 0
BGP table version 11
asic1: BGP router identifier 192.0.0.2, local AS number 65100 vrf-id 0
BGP table version 12
RIB entries 0, using 0 bytes of memory
Peers 0, using 0 KiB of memory
Peer groups 0, using 0 bytes of memory


Neighbhor    V    AS    MsgRcvd    MsgSent    TblVer    InQ    OutQ    Up/Down    State/PfxRcd    NeighborName
-----------  ---  ----  ---------  ---------  --------  -----  ------  ---------  --------------  --------------

Total number of neighbors 0
autotest@sonic:~$

How to verify it

UT and chassis and test the command on pizza box sonic

Previous command output (if the output of a command-line utility has changed)

admin@sonic:~$ show ip bgp summary

IPv4 Unicast Summary:
asic0: BGP router identifier 10.212.65.8, local AS number 64902 vrf-id 0
BGP table version 2303
asic1: BGP router identifier 10.212.65.9, local AS number 64902 vrf-id 0
BGP table version 2887
RIB entries 2696, using 496064 bytes of memory
Peers 18, using 13334544 KiB of memory
Peer groups 4, using 256 bytes of memory


Usage: show ip bgp summary [OPTIONS]
Try "show ip bgp summary -h" for help.

Error: peers missing in the bgp_summary
admin@sonic:~$

New command output (if the output of a command-line utility has changed)

autotest@sonic:~$ show ip bgp summary

IPv4 Unicast Summary:
asic0: BGP router identifier 192.0.0.1, local AS number 65100 vrf-id 0
BGP table version 11
asic1: BGP router identifier 192.0.0.2, local AS number 65100 vrf-id 0
BGP table version 12
RIB entries 0, using 0 bytes of memory
Peers 0, using 0 KiB of memory
Peer groups 0, using 0 bytes of memory


Neighbhor    V    AS    MsgRcvd    MsgSent    TblVer    InQ    OutQ    Up/Down    State/PfxRcd    NeighborName
-----------  ---  ----  ---------  ---------  --------  -----  ------  ---------  --------------  --------------

gechiang · 2024-01-06T02:28:54Z

Removed "Request for 202205 branch" label as we will cherry-pick this directly to the msft repo 202205 branch instead,

gechiang · 2024-01-06T03:07:03Z

PR to Cherry-pick to msft repo:
Azure/sonic-utilities.msft#40

…no external neighbors are configured on chassis LC (sonic-net#3099) Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC

mssonicbld · 2024-01-18T01:17:01Z

Cherry-pick PR to 202305: #3125

…no external neighbors are configured on chassis LC (#3099) Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC

…no external neighbors are configured on chassis LC (sonic-net#3099) Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC

mssonicbld · 2024-02-02T01:34:47Z

Cherry-pick PR to 202311: #3143

…no external neighbors are configured on chassis LC (#3099) Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC

…SIC (#3158) This PR #3099 fixes the case where on chassis Linecard there are no BGP neighbors. However, if the Linecard has neighbors on one ASIC but not on other, the command show bgp summary displayed no neighbors. This PR fixes this. How I did it Add check in bgp_util to create empty peer list only once Add UT to cover this case

…SIC (sonic-net#3158) This PR sonic-net#3099 fixes the case where on chassis Linecard there are no BGP neighbors. However, if the Linecard has neighbors on one ASIC but not on other, the command show bgp summary displayed no neighbors. This PR fixes this. How I did it Add check in bgp_util to create empty peer list only once Add UT to cover this case

…SIC (#3158) This PR #3099 fixes the case where on chassis Linecard there are no BGP neighbors. However, if the Linecard has neighbors on one ASIC but not on other, the command show bgp summary displayed no neighbors. This PR fixes this. How I did it Add check in bgp_util to create empty peer list only once Add UT to cover this case

…SIC (sonic-net#3158) This PR sonic-net#3099 fixes the case where on chassis Linecard there are no BGP neighbors. However, if the Linecard has neighbors on one ASIC but not on other, the command show bgp summary displayed no neighbors. This PR fixes this. How I did it Add check in bgp_util to create empty peer list only once Add UT to cover this case

…SIC (#3158) This PR #3099 fixes the case where on chassis Linecard there are no BGP neighbors. However, if the Linecard has neighbors on one ASIC but not on other, the command show bgp summary displayed no neighbors. This PR fixes this. How I did it Add check in bgp_util to create empty peer list only once Add UT to cover this case

…no external neighbors are configured on chassis LC (sonic-net#3099) Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC

…SIC (sonic-net#3158) This PR sonic-net#3099 fixes the case where on chassis Linecard there are no BGP neighbors. However, if the Linecard has neighbors on one ASIC but not on other, the command show bgp summary displayed no neighbors. This PR fixes this. How I did it Add check in bgp_util to create empty peer list only once Add UT to cover this case

arlakshm added 2 commits December 22, 2023 06:00

bgp no neighbors changes

3c3c0a2

remove refactor code to reduce risk

e4093a9

arlakshm mentioned this pull request Dec 22, 2023

[chassis]: Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC #3097

Closed

arlakshm requested review from abdosi and judyjoseph December 22, 2023 06:04

arlakshm self-assigned this Dec 22, 2023

arlakshm added Request for 202205 Branch Request for 202305 Branch Request for 202311 Branch p0 labels Dec 22, 2023

rlhui added the Chassis for 202205 Branch label Jan 2, 2024

abdosi approved these changes Jan 5, 2024

View reviewed changes

abdosi merged commit 9515c64 into master Jan 5, 2024

gechiang removed the Request for 202205 Branch label Jan 6, 2024

gechiang added the included in chassis for 202205 branch indicate that this PR got merged into the "chassis for 202205 branch" label Jan 6, 2024

StormLiangMS added the Approved for 202305 Branch label Jan 18, 2024

mssonicbld mentioned this pull request Jan 18, 2024

[action] [PR:3099] [chassis]: Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC (#3099) #3125

Merged

mssonicbld added the Created PR to 202305 Branch label Jan 18, 2024

mssonicbld added Included in 202305 Branch and removed Created PR to 202305 Branch labels Jan 18, 2024

yxieca added the Approved for 202311 Branch label Feb 2, 2024

mssonicbld mentioned this pull request Feb 2, 2024

[action] [PR:3099] [chassis]: Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC (#3099) #3143

Merged

mssonicbld added the Created PR to 202311 Branch label Feb 2, 2024

mssonicbld added Included in 202311 Branch and removed Created PR to 202311 Branch labels Feb 2, 2024

arlakshm mentioned this pull request Feb 7, 2024

[chassis] fix show bgp summary when no neighbors are present on one ASIC #3158

Merged

mssonicbld mentioned this pull request Feb 12, 2024

[action] [PR:3158] [chassis] fix show bgp summary when no neighbors are present on one ASIC (#3158) #3162

Merged

mssonicbld mentioned this pull request Apr 26, 2024

[action] [PR:3158] [chassis] fix show bgp summary when no neighbors are present on one ASIC (#3158) #3291

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[chassis]: Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC#3099

[chassis]: Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC#3099
abdosi merged 2 commits intomasterfrom
dev/arlakshm/master/fix_bgp_show

arlakshm commented Dec 22, 2023

Uh oh!

gechiang commented Jan 6, 2024

Uh oh!

gechiang commented Jan 6, 2024

Uh oh!

mssonicbld commented Jan 18, 2024

Uh oh!

mssonicbld commented Feb 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

arlakshm commented Dec 22, 2023

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

gechiang commented Jan 6, 2024

Uh oh!

gechiang commented Jan 6, 2024

Uh oh!

mssonicbld commented Jan 18, 2024

Uh oh!

mssonicbld commented Feb 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants