[config]: Add IP subgroup commands#308
Conversation
|
How about changing ip address? Does it require remove/add or just add will overwrite? |
|
@prsunny It requires remove/add. Since we support multiple IP addresses. |
config/main.py
Outdated
There was a problem hiding this comment.
You removed the recent interface_alias_to_name() alias-to-name translation addition here and below. Just wanted to check if this was overlooked because it's new. Do we want to maintain the ability to bring ports up/down by their vendor alias? @lguohan: do you have an opinion on this?
There was a problem hiding this comment.
Thanks for the feedback. I believe it is better to retain the ability of using vendor alias as an option. I will see how to update the pull request to fix this issue.
There was a problem hiding this comment.
@jleveque I have added the support for the get_interface_mode() == "alias"
config interface <interface_name> add <ip_addr> config interface <interface_name> remove <ip_addr> These two commands are used to configure IP addresses config interface <interface_name> startup config interface <interface_name> shutdown These two commands are moved under interface subgroup, and the order of the arguments are swapped to match the rest of the commands Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
|
thanks! |
* [Cloudlight] QSFP-DD FW upgrade doesn't work (sonic-net#257) - Description cdb1_chkstatus will crash when i2c NACK or timeout. - Motivation and Context I2C of transceiver might NACK or stretching when FW upgrade, assuming "None" means "CdbIsBusy" until timeout. * [Cloudlight] QSFP-DD FW upgrade doesn't work (sonic-net#257) - Description Waiting a delay in "run_fw_image" to ensure it is really executed. Return a special package when get none in "get_module_fw_info". - Motivation and Context "run_fw_image" will be executed after a delay which according to run cmd, waiting the delay in "run_fw_image" to avoid aother cmd sent before it really executing. CDB cmds will maybe cause several seconds NACK or stretching on i2c bus depend on implementation of module vendor, handling this situation for compatible with different implementation. * [Cloudlight] QSFP-DD FW upgrade doesn't work (sonic-net#257) - Description Using real length to replace fixed number in "block_write_epl" function. - Motivation and Context To avoid a wrong epl length used in module. * Update unit tests for cmis. Test : Creating "get_module_fw_info" test.
config interface <interface_name> add <ip_addr>
config interface <interface_name> remove <ip_addr>
These two commands are used to configure IP addresses
config interface <interface_name> startup
config interface <interface_name> shutdown
These two commands are moved under interface subgroup, and
the order of the arguments are swapped to match the rest of
the commands
Signed-off-by: Shu0T1an ChenG shuche@microsoft.com